Retry failed HTTP(S) fetches when appropriate. #118
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@achimnol if you could take a look, I'd appreciate it. |
jsirois
commented
Jan 5, 2025
| reraise=True, | ||
| retry=retry_if_exception( | ||
| lambda ex: ( | ||
| isinstance(ex, TimeoutException) |
There was a problem hiding this comment.
N.B.: I tested most of this config by using a temporary low timeout on the httpx.Client. You do get 2 warning logs before the 2 retries and the final exception is the timeout of the last try.
jsirois
commented
Jan 5, 2025
| @@ -99,6 +135,7 @@ def _fetch_to_cache( | |||
| configured_client(url, headers).stream("GET", url) as response, | |||
| work.open("wb") as cache_fp, | |||
| ): | |||
| response.raise_for_status() | |||
There was a problem hiding this comment.
This missing response.raise_for_status and the one added below were likely bugs that may combine with the rest of this code to actually fix the OP issue. Discussion here: #116 (comment)
Even if not, I'd like to proceed with the change since retries seem like a good idea to me independently of #116.
huonw
approved these changes
Jan 5, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #116