Skip to content

Commit

Permalink
Fix ptex being included in all scies. (#124)
Browse files Browse the repository at this point in the history
Only include it when needed.

The over-eager inclusion originated here in the 0.11.0 release:
#120 (comment)
  • Loading branch information
jsirois authored Jan 13, 2025
1 parent 3f34db5 commit 0e9e616
Show file tree
Hide file tree
Showing 4 changed files with 10 additions and 2 deletions.
6 changes: 6 additions & 0 deletions CHANGES.md
Original file line number Diff line number Diff line change
@@ -1,5 +1,11 @@
# Release Notes

## 0.11.2

This release fixes a bug introduced in the 0.11.0 release whereby a `ptex` binary was always
included in each built scie even when the scie did not use `ptex`. This was functionally harmless
but did bloat the size of the resulting scie binary by ~5MB.

## 0.11.1

This release brings two fixes for `science` on Windows:
Expand Down
2 changes: 1 addition & 1 deletion science/__init__.py
Original file line number Diff line number Diff line change
Expand Up @@ -3,6 +3,6 @@

from packaging.version import Version

__version__ = "0.11.1"
__version__ = "0.11.2"

VERSION = Version(__version__)
2 changes: 2 additions & 0 deletions science/dataclass/deserializer.py
Original file line number Diff line number Diff line change
Expand Up @@ -41,6 +41,8 @@ def _parse_field(
),
),
)
if not data_value and default is None:
return cast(_F, None)
return cast(_F, parse(data_value, dataclass_type, custom_parsers=custom_parsers))

if type_.istype(int):
Expand Down
2 changes: 1 addition & 1 deletion uv.lock

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

0 comments on commit 0e9e616

Please sign in to comment.