-
Notifications
You must be signed in to change notification settings - Fork 48
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Field guide section on YSOs #35
base: main
Are you sure you want to change the base?
Conversation
Thanks @AshishMahabal. Please pull in the latest |
Not sure what is failing. Lint checks only changed files. |
You got trailing whitespaces in |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks @AshishMahabal. I have a few minor comments.
cv_U_Gem: | ||
coordinates: [18.884181, 37.626534] | ||
title: Cataclysmic variable (U Gem dwarf nova) | ||
cv_Z_Cam: | ||
coordinates: [269.093260, 2.967803] | ||
title: Cataclysmic variable (Z Cam dwarf nova) | ||
cv_SU_UMa: | ||
coordinates: [170.883476, 43.288214] | ||
title: Cataclysmic variable (SU UMa/WZ Sge dwarf nova) | ||
cv_Novalike: | ||
coordinates: [322.961689, 49.233813] | ||
title: Cataclysmic variable (Novalike) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This is already on main, looks like you need to rebase this branch off it or just pull it in.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
What would the commands be?
@@ -0,0 +1,101 @@ | |||
ra,dec |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The RA/Dec plot will be like a single blob. Do we want to get more generic?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
We will add objects from other parts later.
|
||
|
||
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Since the linting works only on modified files, I did this file by hand (when I had the malloc errors I did some python plus venv switching, and for some reason this file didn't throw lint errors on my terminal, but did when committed). The blank lines seemed to have escaped.
 | ||
|
||
### References and further reading: | ||
- |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Need references.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Yes, Lynne is to provide some.
@AshishMahabal ping! |
Basic text and examples from Lynne. Starting this so that we can see what is missing and add that.