Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: small UI issues #592

Merged
merged 6 commits into from
Nov 13, 2023
Merged

fix: small UI issues #592

merged 6 commits into from
Nov 13, 2023

Conversation

miguel-nascimento
Copy link
Contributor

@miguel-nascimento miguel-nascimento commented Nov 8, 2023

This PR solves:

  • overflow in playground header applet slug
    Previous on Windows using Chrome:
    image
    now on Windows using Chrome:
    image

  • Padding bottom in markdown preview: previously, the content was hitting the bottom edge of the screen

  • Secrets auto suggestions: previously, the input was popping the auto complete suggestions, leaking previous secrets

Copy link

vercel bot commented Nov 8, 2023

@miguel-nascimento is attempting to deploy a commit to the Zipper Inc Team on Vercel.

To accomplish this, @miguel-nascimento needs to request access to the Team.

Afterwards, an owner of the Team is required to accept their membership request.

If you're already a member of the respective Vercel Team, make sure that your Personal Vercel Account is connected to your GitHub account.

@miguel-nascimento miguel-nascimento changed the title fix: overflow in playground header applet slug fix: small UI issues Nov 8, 2023
@miguel-nascimento miguel-nascimento self-assigned this Nov 8, 2023
@miguel-nascimento miguel-nascimento added the 🐞 bug Something isn't working label Nov 8, 2023
@imadha
Copy link
Contributor

imadha commented Nov 9, 2023

👍

@imadha
Copy link
Contributor

imadha commented Nov 9, 2023

@miguel-nascimento can you sign into vercel and join the zipper.org? should make that red x go way and you can merge then

@miguel-nascimento
Copy link
Contributor Author

requested!

Copy link

vercel bot commented Nov 10, 2023

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
zipper-run ✅ Ready (Inspect) Visit Preview 💬 Add feedback Nov 10, 2023 8:33pm

Copy link

vercel bot commented Jan 16, 2024

An owner of the Zipper Inc Team on Vercel declined @miguel-nascimento's request to join.

In order for their commit to be deployed, @miguel-nascimento must push and request access again.

@miguel-nascimento miguel-nascimento deleted the miguel/header-overflow branch January 16, 2024 13:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
🐞 bug Something isn't working
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants