Skip to content

Commit

Permalink
Update standard.md: fixed some errors
Browse files Browse the repository at this point in the history
  • Loading branch information
0xScratch authored and ZhangZhuoSJTU committed May 12, 2024
1 parent 6439537 commit 125af7a
Showing 1 changed file with 2 additions and 2 deletions.
4 changes: 2 additions & 2 deletions docs/standard.md
Original file line number Diff line number Diff line change
Expand Up @@ -150,7 +150,7 @@ The bug can be classified as either __S3-2__ or __S6-4__, but the root cause is

When a user tries to withdraw the token from the vault, the vault would withdraw the token from the controller if there's insufficient liquidity in the vault. However, the controller does not raise an error when there's insufficient liquidity in the controller/ strategies. The user would lose his shares while getting nothing.

An MEV searcher could apply this attack on any withdrawal. When an attacker found an unconfirmed tx that tries to withdraw 1M DAI, he can do such sandwich attack.
An MEV searcher could apply this attack on any withdrawal. When an attacker finds an unconfirmed tx that tries to withdraw 1M DAI, he can do such sandwich attack.

1. Deposits USDC into the vault.
2. Withdraw all DAI left in the vault/controller/strategy.
Expand Down Expand Up @@ -246,7 +246,7 @@ function collectRentUser(address _user, uint256 _timeToCollectTo)

Now, we can do the same for all the users bidding for a specific token.

Finally, I can become the owner of the token by just calling `newRental` and using a small price. `newRental` will iterate over all the previous bid and will remove them because there are foreclosed.
Finally, I can become the owner of the token by just calling `newRental` and using a small price. `newRental` will iterate over all the previous bids and will remove them because they are foreclosed.


### Explanation
Expand Down

0 comments on commit 125af7a

Please sign in to comment.