Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Create Developer Tools #2734

Open
wants to merge 4 commits into
base: master
Choose a base branch
from
Open

Conversation

myxmaster
Copy link
Contributor

Description

This fixes #117 by adding Developer Tools.

Added a monospace font for the response (Android only so far).

grafik
grafik
grafik
grafik

This pull request is categorized as a:

  • New feature
  • Bug fix
  • Code refactor
  • Configuration change
  • Locales update
  • Quality assurance
  • Other

Checklist

  • I’ve run yarn run tsc and made sure my code compiles correctly
  • I’ve run yarn run lint and made sure my code didn’t contain any problematic patterns
  • I’ve run yarn run prettier and made sure my code is formatted correctly
  • I’ve run yarn run test and made sure all of the tests pass

Testing

If you modified or added a utility file, did you add new unit tests?

  • No, I’m a fool
  • Yes
  • N/A

I have tested this PR on the following platforms (please specify OS version and phone model/VM):

  • Android
  • iOS

I have tested this PR with the following types of nodes (please specify node version and API version where appropriate):

  • Embedded LND
  • LND (REST)
  • LND (Lightning Node Connect)
  • Core Lightning (CLNRest)
  • LndHub
  • [DEPRECATED] Core Lightning (c-lightning-REST)
  • [DEPRECATED] Core Lightning (Spark)
  • [DEPRECATED] Eclair

Locales

  • I’ve added new locale text that requires translations
  • I’m aware that new translations should be made on the ZEUS Transfix page and not directly to this repo

Third Party Dependencies and Packages

  • Contributors will need to run yarn after this PR is merged in
  • 3rd party dependencies have been modified:
    • verify that package.json and yarn.lock have been properly updated
    • verify that dependencies are installed for both iOS and Android platforms

Other:

  • Changes were made that require an update to the README
  • Changes were made that require an update to onboarding

@kaloudis kaloudis added this to the v0.10.0 milestone Jan 14, 2025
@kaloudis kaloudis added the Tools label Jan 14, 2025
views/Tools.tsx Outdated Show resolved Hide resolved
@kaloudis kaloudis requested a review from shubhamkmr04 January 21, 2025 01:24
Copy link
Contributor

@shubhamkmr04 shubhamkmr04 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Screenshot_1737449213
we can't see the borderRadius of response container in the bottom

Copy link
Contributor

@shubhamkmr04 shubhamkmr04 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can we also probably add a feature to clear the response ?

@myxmaster
Copy link
Contributor Author

Can we also probably add a feature to clear the response ?

The autistic part in me was also thinking about that, but then again you can just leave the screen and it will be reset. And other calls also always clear the response first.
What do you think @kaloudis?

@kaloudis
Copy link
Contributor

Can we also probably add a feature to clear the response ?

The autistic part in me was also thinking about that, but then again you can just leave the screen and it will be reset. And other calls also always clear the response first. What do you think @kaloudis?

I think we have real estate in the top right corner for a clear button. It would be half the steps of leaving the page and returning.

@myxmaster
Copy link
Contributor Author

It would be half the steps of leaving the page and returning.

Yes, only question is, why would somebody want/need it?

@kaloudis
Copy link
Contributor

It would be half the steps of leaving the page and returning.

Yes, only question is, why would somebody want/need it?

In the screenshot above you have a response that takes up the whole view. Instead of scrolling for some time to get back to the next response you want, you could simply have a button that resets the view.

@myxmaster
Copy link
Contributor Author

Or an icon to scroll to the top. I personally would like that better. Let me know what you prefer.

@myxmaster
Copy link
Contributor Author

Maybe we can have an icon on bottom right corner, that starts to be displayed if you scroll down... A click on that would scroll all the way to the top immediately.

@myxmaster
Copy link
Contributor Author

Looks pretty good imo:
grafik

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add debug mode
3 participants