Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

LSP-101: LSPS1: Explicitly support LSPS1 payment options #2260

Merged
merged 2 commits into from
Jun 25, 2024

Conversation

kaloudis
Copy link
Contributor

Description

Spec PR: BitcoinAndLightningLayerSpecs/lsp#101

Waiting for some clarification as we believe there is an error with the response on GetOrder seen here: https://github.com/BitcoinAndLightningLayerSpecs/lsp/pull/101/files#diff-ab5804bf6551fffb4e731a7e5f636a2e6ac697af875bc15c2bca9448ff06d645R292

Comments on the Telegram group:

RE LSPS1, createOrder and getOrder show parameters invoice and bolt11_invoice respectively for the property under the bolt11 object. I think the intention is to keep the response uniform, yeah? @erikdesmedt

This pull request is categorized as a:

  • New feature
  • Bug fix
  • Code refactor
  • Configuration change
  • Locales update
  • Quality assurance
  • Other

Checklist

  • I’ve run yarn run tsc and made sure my code compiles correctly
  • I’ve run yarn run lint and made sure my code didn’t contain any problematic patterns
  • I’ve run yarn run prettier and made sure my code is formatted correctly
  • I’ve run yarn run test and made sure all of the tests pass

Testing

If you modified or added a utility file, did you add new unit tests?

  • No, I’m a fool
  • Yes
  • N/A

I have tested this PR on the following platforms (please specify OS version and phone model/VM):

  • Android
  • iOS

I have tested this PR with the following types of nodes (please specify node version and API version where appropriate):

  • Embedded LND
  • LND (REST)
  • LND (Lightning Node Connect)
  • Core Lightning (c-lightning-REST)
  • LndHub
  • [DEPRECATED] Core Lightning (Spark)
  • [DEPRECATED] Eclair

Locales

  • I’ve added new locale text that requires translations
  • I’m aware that new translations should be made on the ZEUS Transfix page and not directly to this repo

Third Party Dependencies and Packages

  • Contributors will need to run yarn after this PR is merged in
  • 3rd party dependencies have been modified:
    • verify that package.json and yarn.lock have been properly updated
    • verify that dependencies are installed for both iOS and Android platforms

Other:

  • Changes were made that require an update to the README
  • Changes were made that require an update to onboarding

@kaloudis kaloudis added this to the v0.9.0 milestone Jun 21, 2024
@kaloudis kaloudis requested a review from shubhamkmr04 June 21, 2024 18:16
@kaloudis kaloudis marked this pull request as ready for review June 24, 2024 03:56
@kaloudis kaloudis merged commit 000391e into ZeusLN:master Jun 25, 2024
3 checks passed
@kaloudis kaloudis deleted the lsp-101 branch June 25, 2024 00:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant