Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

AmountInput enhancements #2258

Merged
merged 1 commit into from
Jun 25, 2024
Merged

Conversation

kaloudis
Copy link
Contributor

@kaloudis kaloudis commented Jun 20, 2024

Description

This PR seeks to address issues with the AmountInput component raised in comment #2245 (comment)

  • I personally find it a bit irritating when the input is pre-filled with a "0" (not as placeholder, but really the value for the text input).

This is directly addressed by this PR

  • Block entering of invalid chars (anything but numbers and decimal separators should be ignored for amount inputs)

This is directly addressed by this PR

  • Remove invalid chars if pasted (e.g. somebody is pasting "12 304 sats", it should result to "12304")

This is directly addressed by this PR

  • Allow leading zeros but remove them internally when whatever process is continued (product saved, invoice created etc.)

This is already addressed by UnitStore's getFormattedAmount - though we can discuss how this behavior can be changed.

This pull request is categorized as a:

  • New feature
  • Bug fix
  • Code refactor
  • Configuration change
  • Locales update
  • Quality assurance
  • Other

Checklist

  • I’ve run yarn run tsc and made sure my code compiles correctly
  • I’ve run yarn run lint and made sure my code didn’t contain any problematic patterns
  • I’ve run yarn run prettier and made sure my code is formatted correctly
  • I’ve run yarn run test and made sure all of the tests pass

Testing

If you modified or added a utility file, did you add new unit tests?

  • No, I’m a fool
  • Yes
  • N/A

I have tested this PR on the following platforms (please specify OS version and phone model/VM):

  • Android
  • iOS

I have tested this PR with the following types of nodes (please specify node version and API version where appropriate):

  • Embedded LND
  • LND (REST)
  • LND (Lightning Node Connect)
  • Core Lightning (c-lightning-REST)
  • LndHub
  • [DEPRECATED] Core Lightning (Spark)
  • [DEPRECATED] Eclair

Locales

  • I’ve added new locale text that requires translations
  • I’m aware that new translations should be made on the ZEUS Transfix page and not directly to this repo

Third Party Dependencies and Packages

  • Contributors will need to run yarn after this PR is merged in
  • 3rd party dependencies have been modified:
    • verify that package.json and yarn.lock have been properly updated
    • verify that dependencies are installed for both iOS and Android platforms

Other:

  • Changes were made that require an update to the README
  • Changes were made that require an update to onboarding

@kaloudis kaloudis changed the title AmountInput enhancements AmountInput enhancements Jun 20, 2024
@myxmaster
Copy link
Contributor

Very nice.

About leading zeros: It is not that relevant, but I can enter ₿ "00.05" and save the product. When I reopen it, it stays 00.05:
grafik

Would be cool if it internally converts into 0.05.

@kaloudis
Copy link
Contributor Author

Very nice.

About leading zeros: It is not that relevant, but I can enter ₿ "00.05" and save the product. When I reopen it, it stays 00.05: grafik

Would be cool if it internally converts into 0.05.

Let's make another issue for this as there is some more complexity here.

@kaloudis kaloudis force-pushed the amountinput-enhancements branch from 268c38d to 2f845d1 Compare June 20, 2024 21:19
@kaloudis kaloudis closed this Jun 20, 2024
@kaloudis kaloudis reopened this Jun 20, 2024
@kaloudis kaloudis closed this Jun 20, 2024
@kaloudis kaloudis reopened this Jun 20, 2024
@kaloudis kaloudis closed this Jun 20, 2024
@kaloudis kaloudis reopened this Jun 20, 2024
@kaloudis
Copy link
Contributor Author

Very nice.

About leading zeros: It is not that relevant, but I can enter ₿ "00.05" and save the product. When I reopen it, it stays 00.05: grafik

Would be cool if it internally converts into 0.05.

#2259

@kaloudis kaloudis merged commit 577bcef into ZeusLN:master Jun 25, 2024
12 of 16 checks passed
@kaloudis kaloudis deleted the amountinput-enhancements branch June 25, 2024 00:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants