fix(ci): improve workflow conditions for cached disk jobs #9274
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
gustavovalverde
added
C-bug
gustavovalverde
requested review from
oxarbitrage
and removed request for
a team
gustavovalverde
changed the title
github-actions
bot
added
C-trivial
upbqdn
previously approved these changes
Feb 19, 2025
|
I made this depend on #9269 as it will need those fixes for full validation |
Merge ProtectionsYour pull request matches the following merge protections and will not be merged until they are valid. 🟢 ⛓️ Depends-On RequirementsWonderful, this rule succeeded.Requirement based on the presence of
|
|
@mergify rebase |
Refactor GitHub workflow conditions to: - Handle workflow dispatch events more precisely - Prevent running cached disk jobs on forked PRs - Ensure consistent behavior across different deployment workflows - Avoid skipping main branch deployments - Updated the if condition for the deploy-nodes job to ensure it only runs when the build job runs successfully and is not skipped.
✅ Branch has been successfully rebased |
gustavovalverde
force-pushed
the
fix-deploy-conditions
branch
from
20e4d54 to
7feef23
Compare
- Comment out the `test-zebra-conf-path` job in the deployment workflow - Fix a syntax error in the GCP resource deletion workflow's condition - Remove an extra single quote in the `if` condition for the `clean-registries` job
oxarbitrage
approved these changes
Feb 19, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation
Deployments are running successfully, but as we do not have healthcheck in place (yet), the instances were not being raised as the image digest was missing.
This was causing the Zebra nodes to get deployed with an unusable image reference in GCP.
Depends-On: #9269
Solution
Refactored GitHub workflow conditions to:
Follow-up Work
We need healtchecks
PR Author's Checklist
PR Reviewer's Checklist