Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

cleanup(logger): Replace last log mutex with watch channel #9262

Merged
merged 1 commit into from
Feb 18, 2025
Merged

cleanup(logger): Replace last log mutex with watch channel #9262

merged 1 commit into from
Feb 18, 2025

Conversation

arya2
Copy link
Contributor

@arya2 arya2 commented Feb 17, 2025 •
edited
Loading

This is a cleanup PR for replacing a Mutex sharing the last warning or error log message with a watch channel.

There should be no concurrency issues with the Mutex as it's currently used, so this is only cleanup to enable extending its use without any concurrency considerations.

@arya2 arya2 requested review from a team as code owners February 17, 2025 23:13
@arya2 arya2 requested review from oxarbitrage and removed request for a team February 17, 2025 23:13
@arya2 arya2 changed the base branch from main to extend-getinfo February 17, 2025 23:13
@github-actions github-actions bot added the C-feature Category: New features label Feb 17, 2025
@arya2 arya2 self-assigned this Feb 17, 2025
@arya2 arya2 added A-concurrency Area: Async code, needs extra work to make it work properly. and removed C-feature Category: New features labels Feb 17, 2025
@arya2 arya2 mentioned this pull request Feb 18, 2025
Merged
7 tasks
Base automatically changed from extend-getinfo to main February 18, 2025 03:23
@arya2 arya2 changed the title Suggestions for "feature(rpc): Extend getinfo #9261" cleanup(logger): Replace last log mutex with watch channel Feb 18, 2025
@arya2 arya2 force-pushed the extend-getinfo-suggestion branch from 602f508 to 162f79d Compare February 18, 2025 03:43
@github-actions github-actions bot added the C-trivial Category: A trivial change that is not worth mentioning in the CHANGELOG label Feb 18, 2025
@mpguerra mpguerra linked an issue Feb 18, 2025 that may be closed by this pull request
Update getinfo RPC method #8448
Closed
oxarbitrage
oxarbitrage approved these changes Feb 18, 2025
View reviewed changes
Copy link
Contributor

@oxarbitrage oxarbitrage left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yea, this is a lot better. I need to remember to use a channel instead of a mutex in the future. Thanks for the cleanup.

@mergify mergify bot merged commit 9591c00 into main Feb 18, 2025
75 checks passed
@mergify mergify bot deleted the extend-getinfo-suggestion branch February 18, 2025 11:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@oxarbitrage oxarbitrage oxarbitrage approved these changes

Assignees

@arya2 arya2

Labels
A-concurrency Area: Async code, needs extra work to make it work properly. C-trivial Category: A trivial change that is not worth mentioning in the CHANGELOG P-Optional ✨
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Update getinfo RPC method
2 participants
@arya2 @oxarbitrage