Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(config): Correctly serialize testnet parameters into toml config format #9224

Merged
merged 1 commit into from
Feb 12, 2025

Conversation

arya2
Copy link
Contributor

@arya2 arya2 commented Feb 11, 2025

Motivation

This PR correctly serializes testnet parameters into the toml config format.

Closes #8920.

Solution

Converts Config to DConfig before serializing.

Tests

Adds a roundtrip serialization test.

Follow-up Work

Add an acceptance test for #9201.

PR Author's Checklist

  • The PR name will make sense to users.
  • The PR provides a CHANGELOG summary.
  • The solution is tested.
  • The documentation is up to date.
  • The PR has a priority label.

PR Reviewer's Checklist

  • The PR Author's checklist is complete.
  • The PR resolves the issue.

@arya2 arya2 added C-enhancement Category: This is an improvement C-cleanup Category: This is a cleanup C-testing Category: These are tests C-tech-debt Category: Code maintainability issues P-Medium ⚡ labels Feb 11, 2025
@arya2 arya2 self-assigned this Feb 11, 2025
@arya2 arya2 requested review from a team as code owners February 11, 2025 04:17
@arya2 arya2 requested review from conradoplg and removed request for a team February 11, 2025 04:17
@github-actions github-actions bot added the C-trivial Category: A trivial change that is not worth mentioning in the CHANGELOG label Feb 11, 2025
Copy link
Contributor

@oxarbitrage oxarbitrage left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good, thanks!

mergify bot added a commit that referenced this pull request Feb 12, 2025
Copy link
Contributor

mergify bot commented Feb 12, 2025

This pull request has been removed from the queue for the following reason: checks failed.

The merge conditions cannot be satisfied due to failing checks:

You should look at the reason for the failure and decide if the pull request needs to be fixed or if you want to requeue it.

If you want to requeue this pull request, you need to post a comment with the text: @mergifyio requeue

@arya2
Copy link
Contributor Author

arya2 commented Feb 12, 2025

@Mergifyio refresh

Copy link
Contributor

mergify bot commented Feb 12, 2025

refresh

✅ Pull request refreshed

mergify bot added a commit that referenced this pull request Feb 12, 2025
Copy link
Contributor

mergify bot commented Feb 12, 2025

This pull request has been removed from the queue for the following reason: checks failed.

The merge conditions cannot be satisfied due to failing checks:

You should look at the reason for the failure and decide if the pull request needs to be fixed or if you want to requeue it.

If you want to requeue this pull request, you need to post a comment with the text: @mergifyio requeue

@arya2
Copy link
Contributor Author

arya2 commented Feb 12, 2025

@Mergifyio refresh

Copy link
Contributor

mergify bot commented Feb 12, 2025

refresh

✅ Pull request refreshed

mergify bot added a commit that referenced this pull request Feb 12, 2025
Copy link
Contributor

mergify bot commented Feb 12, 2025

This pull request has been removed from the queue for the following reason: checks failed.

The merge conditions cannot be satisfied due to failing checks:

You should look at the reason for the failure and decide if the pull request needs to be fixed or if you want to requeue it.

If you want to requeue this pull request, you need to post a comment with the text: @mergifyio requeue

@arya2
Copy link
Contributor Author

arya2 commented Feb 12, 2025

@Mergifyio refresh

Copy link
Contributor

mergify bot commented Feb 12, 2025

refresh

✅ Pull request refreshed

mergify bot added a commit that referenced this pull request Feb 12, 2025
mergify bot added a commit that referenced this pull request Feb 12, 2025
@mergify mergify bot merged commit 35e400b into main Feb 12, 2025
145 checks passed
@mergify mergify bot deleted the fix-testnet-param-serialization branch February 12, 2025 17:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
C-cleanup Category: This is a cleanup C-enhancement Category: This is an improvement C-tech-debt Category: Code maintainability issues C-testing Category: These are tests C-trivial Category: A trivial change that is not worth mentioning in the CHANGELOG P-Medium ⚡
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Serialize testnet::Parameters in ZebradConfig
2 participants