Bug Fix

YunusEmreAlps · Nov 9, 2021 · c7fad77 · c7fad77
1 parent d2eb77c
commit c7fad77
Show file tree

Hide file tree

Showing 5 changed files with 15 additions and 25 deletions.
diff --git a/find_mentor/lib/ui/components/jobsdetailpage/job_description_card.dart b/find_mentor/lib/ui/components/jobsdetailpage/job_description_card.dart
@@ -40,10 +40,7 @@ class JobDescriptionCard extends StatelessWidget {
         crossAxisAlignment: CrossAxisAlignment.start,
         children: [
           SizedBox(height: 12),
-          Positioned(
-            top: 50,
-            left: 20,
-            right: 20,
+          Container(
             child: Row(
               mainAxisAlignment: MainAxisAlignment.spaceBetween,
               children: [

diff --git a/find_mentor/lib/ui/components/personsdetailpage/person_description_card.dart b/find_mentor/lib/ui/components/personsdetailpage/person_description_card.dart
@@ -40,10 +40,7 @@ class PersonDescriptionCard extends StatelessWidget {
         crossAxisAlignment: CrossAxisAlignment.start,
         children: [
           SizedBox(height: 12),
-          Positioned(
-            top: 50,
-            left: 20,
-            right: 20,
+          Container(
             child: Row(
               mainAxisAlignment: MainAxisAlignment.spaceBetween,
               children: [
@@ -77,10 +74,7 @@ class PersonDescriptionCard extends StatelessWidget {
             height: 1.5,
           ),
           SizedBox(height: 12),
-          Positioned(
-            top: 50,
-            left: 20,
-            right: 20,
+          Container(
             child: Row(
               mainAxisAlignment: MainAxisAlignment.spaceBetween,
               children: [

diff --git a/find_mentor/lib/ui/components/personsdetailpage/person_github_card.dart b/find_mentor/lib/ui/components/personsdetailpage/person_github_card.dart
@@ -42,10 +42,7 @@ class PersonGitHubCard extends StatelessWidget {
         crossAxisAlignment: CrossAxisAlignment.start,
         children: [
           SizedBox(height: 12),
-          Positioned(
-            top: 50,
-            left: 20,
-            right: 20,
+          Container(
             child: Row(
               mainAxisAlignment: MainAxisAlignment.spaceBetween,
               children: [

diff --git a/find_mentor/lib/ui/view/home/jobs_detail_page/jobs_detail_page_body.dart b/find_mentor/lib/ui/view/home/jobs_detail_page/jobs_detail_page_body.dart
@@ -54,13 +54,14 @@ class _JobsDetailPageBodyState extends State<JobsDetailPageBody> {
                           ),
                           SizedBox(height: 16),
                           JobDescriptionCard(
-                              model: widget.jobDetail,
-                              onApplyTap: () {
-                                controller.animateTo(
-                                    controller.position.maxScrollExtent,
-                                    duration: Duration(milliseconds: 500),
-                                    curve: Curves.linearToEaseOut);
-                              }),
+                            model: widget.jobDetail,
+                            onApplyTap: () {
+                              controller.animateTo(
+                                  controller.position.maxScrollExtent,
+                                  duration: Duration(milliseconds: 500),
+                                  curve: Curves.linearToEaseOut);
+                            },
+                          ),
                         ],
                       ),
                     ),

diff --git a/find_mentor/lib/ui/view/home/persons_detail_page/persons_detail_page_body.dart b/find_mentor/lib/ui/view/home/persons_detail_page/persons_detail_page_body.dart
@@ -64,7 +64,8 @@ class _PersonsDetailPageBodyState extends State<PersonsDetailPageBody> {
                                     curve: Curves.linearToEaseOut);
                               }),
                           SizedBox(height: 16),
-                          FutureBuilder(
+                          (widget.personDetail.github.length != 0) 
+                          ? FutureBuilder(
                             future: fetchReadMe(widget.personDetail.github.substring(19)),
                             builder: (context, snapshot) {
                               if (snapshot.hasData) {
@@ -80,7 +81,7 @@ class _PersonsDetailPageBodyState extends State<PersonsDetailPageBody> {
                               }
                               return Container();
                             },
-                          ),
+                          ) : Container(),
                         ],
                       ),
                     ),