Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Change source back to release (was changed to archives) #212

Merged

Conversation

e-jim
Copy link
Contributor

@e-jim e-jim commented Jul 15, 2024

Problem

Solution

  • I set the source back to release files instead of archives of the repo

PR Status

  • Code finished and ready to be reviewed/tested
  • The fix/enhancement were manually tested (on my own instance)

Automatic tests

Automatic tests can be triggered on https://ci-apps-dev.yunohost.org/ after creating the PR, by commenting "!testme", "!gogogadgetoci" or "By the power of systemd, I invoke The Great App CI to test this Pull Request!". (N.B. : for this to work you need to be a member of the Yunohost-Apps organization)

@e-jim
Copy link
Contributor Author

e-jim commented Jul 15, 2024

In my (very) humble opinion, it's a better solution than #211 as it doesn't add a new dependency.

@MadMan247
Copy link

MadMan247 commented Jul 16, 2024

I just installed this branch, and it works like a charm. I wouldn't have thought that the archived releases would be different from the regular releases, other than being simply saved for later. What tipped you off?

And I 100% agree that this is a better solution than #211 - not even a question.

You're the goat, and I hope a maintainer or member of yunohost merges this pull request asap.

This fixes issues #200 #201 #204 and #210

Should probably be pushing this to the testing branch though. I'm not sure how strict they are on these things.

@alexAubin
Copy link
Member

Eugarghr should have merged to testing ... will fix that

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Installation theme issue
3 participants