From de889bb3b84058c1dbfc28fea5e57dd44efe5eba Mon Sep 17 00:00:00 2001 From: WRXinYue <3322543587@qq.com> Date: Fri, 19 Apr 2024 20:29:02 +0800 Subject: [PATCH 1/2] fix: onMounted to cause component exception --- .../valaxy-addon-meting/client/observer.ts | 4 ---- packages/valaxy-addon-meting/client/utils.ts | 22 +++++-------------- 2 files changed, 5 insertions(+), 21 deletions(-) diff --git a/packages/valaxy-addon-meting/client/observer.ts b/packages/valaxy-addon-meting/client/observer.ts index 51bf671db..78e32ce11 100644 --- a/packages/valaxy-addon-meting/client/observer.ts +++ b/packages/valaxy-addon-meting/client/observer.ts @@ -22,10 +22,6 @@ export function setupHiddenLyricHidingObserver() { }) }) observer.observe(document.body, { childList: true, subtree: true }) - - onUnmounted(() => { - observer?.disconnect() - }) } export function useMetingLoadObserver(addon: MetingOptions) { diff --git a/packages/valaxy-addon-meting/client/utils.ts b/packages/valaxy-addon-meting/client/utils.ts index ecc1bb4ec..de00facb6 100644 --- a/packages/valaxy-addon-meting/client/utils.ts +++ b/packages/valaxy-addon-meting/client/utils.ts @@ -1,5 +1,4 @@ import { useEventListener } from '@vueuse/core' -import { onMounted, onUnmounted } from 'vue' import type { MetingOptions } from '../node/index' import { Hook } from './hook' @@ -19,8 +18,8 @@ export function handleOptions(options: MetingOptions['options'], rules: Rules) { * APlayer mini switcher */ export function useAPlayerMiniSwitcherEventListener() { - let aplayerFixedElement: HTMLElement - let aplayerIconButton: HTMLElement + const aplayerFixedElement = document.querySelector('.aplayer.aplayer-fixed .aplayer-body') as HTMLElement + const aplayerIconButton = document.querySelector('.aplayer-body .aplayer-miniswitcher .aplayer-icon') as HTMLElement let aplayerNarrow = true function toggleAplayerVisibility() { @@ -36,20 +35,9 @@ export function useAPlayerMiniSwitcherEventListener() { aplayerFixedElement.style.left = '0' } - onMounted(() => { - aplayerFixedElement = document.querySelector('.aplayer.aplayer-fixed .aplayer-body') as HTMLElement - aplayerIconButton = document.querySelector('.aplayer-body .aplayer-miniswitcher .aplayer-icon') as HTMLElement - - useEventListener(aplayerFixedElement, 'mouseenter', showAplayer) - useEventListener(aplayerFixedElement, 'mouseleave', hiddenAplayer) - useEventListener(aplayerIconButton, 'click', toggleAplayerVisibility) - }) - - onUnmounted(() => { - aplayerFixedElement?.removeEventListener('mouseenter', showAplayer) - aplayerFixedElement?.removeEventListener('mouseleave', hiddenAplayer) - aplayerIconButton?.removeEventListener('click', toggleAplayerVisibility) - }) + useEventListener(aplayerFixedElement, 'mouseenter', showAplayer) + useEventListener(aplayerFixedElement, 'mouseleave', hiddenAplayer) + useEventListener(aplayerIconButton, 'click', toggleAplayerVisibility) } function handleAplayerAction(action: string, leftValue: string) { From 31bdde91fb39704e655985969000b044c747f204 Mon Sep 17 00:00:00 2001 From: WRXinYue <3322543587@qq.com> Date: Fri, 19 Apr 2024 20:32:39 +0800 Subject: [PATCH 2/2] release(valaxy-addon-meting): release version 0.1.2 --- packages/valaxy-addon-meting/package.json | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/packages/valaxy-addon-meting/package.json b/packages/valaxy-addon-meting/package.json index 94835e7ad..d891876d0 100644 --- a/packages/valaxy-addon-meting/package.json +++ b/packages/valaxy-addon-meting/package.json @@ -1,7 +1,7 @@ { "name": "valaxy-addon-meting", "global": true, - "version": "0.1.1", + "version": "0.1.2", "license": "MIT", "repository": { "url": "https://github.com/YunYouJun/valaxy/tree/main/packages/valaxy-addon-meting",