-
-
Notifications
You must be signed in to change notification settings - Fork 96
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: client redirects at vue router level #336
Conversation
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
@@ -19,6 +20,22 @@ import type { ValaxyNodeConfig } from '../types' | |||
import { checkMd } from '../markdown/check' | |||
import { vLogger } from '../logger' | |||
import { countPerformanceTime } from '../utils/performance' | |||
import { isProd } from '../utils/env' | |||
|
|||
function generateConfig(options: ResolvedValaxyOptions) { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
For now, redirects is defined in siteConfig, so I wonder if we can get the configuration directly from the client without adding extra runtimeConfig.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I guess we can save some code?
I am not directly debugging now, so you can tell me if i have any mistakes.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
When compiling, we need to collect redirect rules from frontmatter, whick are not user-defined. Is it a good idea to put these in siteconfig?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Since I lack experience, if you think this is better, I will modify it.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
OK, you are right, some configs collected from frontmatter.
Description
close #328
Linked Issues
Copilot Descriptions
copilot:all