fix(addon-bangumi): runtime error in browser (#431)

YunYouJun · Aug 24, 2024 · 7cdd0aa · 7cdd0aa · github-actions · Aug 24, 2024
1 parent a58ca38
commit 7cdd0aa
Show file tree

Hide file tree

Showing 2 changed files with 8 additions and 10 deletions.
diff --git a/packages/valaxy-addon-bangumi/components/ValaxyBangumi.vue b/packages/valaxy-addon-bangumi/components/ValaxyBangumi.vue
@@ -1,17 +1,14 @@
 <script setup lang="ts">
-/**
- * The ESM module will be mistakenly identified as CJS. Importing like this:
- * import { defineCustomElements } from "bilibili-bangumi-component/loader";
- *
- * reference https://github.com/YunYouJun/valaxy/pull/346
- */
-// eslint-disable-next-line ts/ban-ts-comment
-// @ts-expect-error
-import { defineCustomElements } from 'bilibili-bangumi-component/dist/cjs/loader.cjs'
 import { onMounted, ref } from 'vue'
+import { isClient } from '@vueuse/core'
 import { useAddonBangumi } from '../client'
 
-defineCustomElements()
+(async () => {
+  if (!isClient)
+    return
+  const { defineCustomElements } = await import('bilibili-bangumi-component/loader')
+  defineCustomElements()
+})()
 
 const bangumiRef = ref<HTMLElement>()
 

diff --git a/packages/valaxy-addon-bangumi/package.json b/packages/valaxy-addon-bangumi/package.json
@@ -1,5 +1,6 @@
 {
   "name": "valaxy-addon-bangumi",
+  "type": "module",
   "version": "0.2.0",
   "description": "Bangumi addon for Valaxy",
   "repository": {