opt_expr: fix sign extension for shifts #5066
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This fixes #5065. When optimizing a shift with constant shift amount, an optimization is used to limit the shift amount to the width of the input, but this limiting was done before potentially increasing the input's size by sign-extending it. This allowed the sign extended parts of the signal to be shifted into the output bits incorrectly. This PR defers the optimization until after the sign extension has happened to handle this and adds tests.
Could someone make sure that this doesn't break anything for
$shift
/$shiftx
before merging please, I wasn't sure where they come from/what the difference is to the other shift cells.