Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add business matches beta endpoints #75

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

Conversation

kfarst
Copy link

@kfarst kfarst commented Apr 7, 2018

Hey there! Not sure if you want to integrate this since they are beta endpoints, but I just had to fork and add methods for the business match API for my own purposes, and just thought I would offer it up as a PR.

The update adds two new public methods for each of the two endpoints:

- (void)findBusinessMatchesWithInfo:(NSDictionary *)info
     completionHandler:(YLPBusinessMatchCompletionHandler)completionHandler;

- (void)bestBusinessMatchWithInfo:(NSDictionary *)info
     completionHandler:(YLPBusinessMatchCompletionHandler)completionHandler;

I also added a new model type, YLPBusinessMatch, since the properties don't exactly line up with a YLPBusiness object. Unit tests are also added for each endpoint.

@dan98765
Copy link
Contributor

@kfarst thanks for the PR, and sorry for the very long delay in response you experienced here.

Since this PR was filed a single, out-of-beta unified business match endpoint in the Fusion API was created and the 2 beta bizmatch endpoints marked as deprecated & scheduled for removal.
Docs: https://www.yelp.com/developers/documentation/v3/business_match

If you're up for updating this to use the single out-of-beta endpoint we can move towards merging it in.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants