Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Upload of Cisco IOS XR 24.2.1, 24.2.2, 24.3.1 Yang Models #1590

Merged
merged 3 commits into from
Oct 8, 2024
Merged

Upload of Cisco IOS XR 24.2.1, 24.2.2, 24.3.1 Yang Models #1590

merged 3 commits into from
Oct 8, 2024

Conversation

Greg-Brown-1
Copy link
Contributor

Upload of Cisco IOS XR 24.2.1, 24.2.2, 24.3.1 Yang Models

ncorran
ncorran approved these changes Oct 8, 2024
View reviewed changes
Copy link

@ncorran ncorran left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Approved valid update of Cisco models

@einarnn
Copy link
Member

einarnn commented Oct 8, 2024 •
edited
Loading

@Greg-Brown-1 -- some errors are currently being ignored by the check scripts for XR. For example, if you look at the logs for the check scripts:

PYANG: Errors in Cisco-IOS-XR-sysadmin-controllers-iosxrwbd.yang
Cisco-IOS-XR-sysadmin-eobc-iosxrwbd.yang:0: error: premature end of file
PYANG: Errors in Cisco-IOS-XR-sysadmin-controllers-iosxrwbd.yang
Cisco-IOS-XR-sysadmin-eobc-iosxrwbd.yang:0: error: premature end of file
PYANG: Errors in Cisco-IOS-XR-sysadmin-eobc-iosxrwbd.yang
Cisco-IOS-XR-sysadmin-eobc-iosxrwbd.yang:0: error: premature end of file
PYANG: Errors in Cisco-IOS-XR-sysadmin-eobc-iosxrwbd.yang
Cisco-IOS-XR-sysadmin-eobc-iosxrwbd.yang:0: error: premature end of file
PYANG: Errors in Cisco-IOS-XR-sysadmin-controllers-iosxrwbd.yang
Cisco-IOS-XR-sysadmin-eobc-iosxrwbd.yang:0: error: premature end of file
PYANG: Errors in Cisco-IOS-XR-sysadmin-eobc-iosxrwbd.yang
Cisco-IOS-XR-sysadmin-eobc-iosxrwbd.yang:0: error: premature end of file
PYANG: Errors in Cisco-IOS-XR-sysadmin-eobc-iosxrwbd.yang
Cisco-IOS-XR-sysadmin-eobc-iosxrwbd.yang:0: error: premature end of file
PYANG: Errors in Cisco-IOS-XR-sysadmin-eobc-iosxrwbd.yang
Cisco-IOS-XR-sysadmin-eobc-iosxrwbd.yang:0: error: premature end of file
PYANG: Errors in Cisco-IOS-XR-sysadmin-fabric-ncs[550](https://github.com/YangModels/yang/actions/runs/11237730374/job/31240815559?pr=1590#step:5:551)0.yang
Cisco-IOS-XR-sysadmin-fabric-ncs5500.yang:8: error: module "Cisco-IOS-XR-sysadmin-fabric-mgr-fsdb-server-ncs5500" not found in search path
Cisco-IOS-XR-sysadmin-fabric-ncs5500.yang:11: error: module "Cisco-IOS-XR-sysadmin-fabric-mgr-fsdb-aggregator-ncs5500" not found in search path
Cisco-IOS-XR-sysadmin-fabric-ncs5500.yang:14: error: module "Cisco-IOS-XR-sysadmin-fabric-driver-sfe-ncs5500" not found in search path
PYANG: Errors in Cisco-IOS-XR-sysadmin-fabric-ncs5502.yang
Cisco-IOS-XR-sysadmin-fabric-ncs5502.yang:14: error: module "Cisco-IOS-XR-sysadmin-fabric-driver-sfe-ncs5500" not found in search path

Just the last errors I saw. Are you planning to sanitize the commits at some time?

I will merge this for now, but would like to see this improve. @ncorran -- is this something you can help with?

@einarnn einarnn merged commit d1929d7 into YangModels:main Oct 8, 2024
1 check passed
@Greg-Brown-1
Copy link
Contributor Author

Will look into these and see how we can fix them. Some might be due to internal issues

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@einarnn einarnn einarnn approved these changes

@ncorran ncorran ncorran approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@Greg-Brown-1 @einarnn @ncorran