Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

adding footer and improving header in responsiveness and appearance #731

Merged
merged 3 commits into from
Nov 10, 2024

Conversation

Riyachauhan11
Copy link
Contributor

@Riyachauhan11 Riyachauhan11 commented Nov 8, 2024

πŸ› οΈ Fixes Issue

Fixes: #720

πŸ‘¨β€πŸ’» Description

What does this PR do?

adds footer and fixes header appearance in light mode and makes header and footer both responsive so game works well in smaller screens

πŸ“„ Type of Change

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • Documentation update (adds or updates related documentation)

πŸ“· Screenshots/GIFs (if any)

Include screenshots or GIFs to demonstrate your changes
image

image

Screenshot_20241109_010024

βœ… Checklist

  • I am a participant of GSSoC-ext.
  • I have followed the contribution guidelines of this project.
  • I have made this change from my own.
  • I have taken help from some online resources.
  • My code follows the style guidelines of this project.
  • I have performed a self-review of my own code.
  • I have added documentation to explain my changes.

Mandatory Tasks

  • Make sure you have self-reviewed the code. A decent size PR without self-review might be rejected.

🀝 GSSoC Participation

  • This PR is submitted under the GSSoC program.
  • I have taken prior approval for this feature/fix.

Copy link

github-actions bot commented Nov 8, 2024

Thank you for submitting your pull request! πŸ™Œ We'll review it as soon as possible. In the meantime, please ensure that your changes align with our chaotic CONTRIBUTING.md. If there are any specific instructions or feedback regarding your PR, we'll provide them here. Thanks again for your contribution! 😊

Copy link

netlify bot commented Nov 8, 2024

βœ… Deploy Preview for alienid ready!

Name Link
πŸ”¨ Latest commit 103af97
πŸ” Latest deploy log https://app.netlify.com/sites/alienid/deploys/672f43a54ded07000877be0c
😎 Deploy Preview https://deploy-preview-731--alienid.netlify.app
πŸ“± Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

Copy link

netlify bot commented Nov 8, 2024

βœ… Deploy Preview for thunderous-starlight-9c463d ready!

Name Link
πŸ”¨ Latest commit 103af97
πŸ” Latest deploy log https://app.netlify.com/sites/thunderous-starlight-9c463d/deploys/672f43a54ded07000877be0a
😎 Deploy Preview https://deploy-preview-731--thunderous-starlight-9c463d.netlify.app
πŸ“± Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@YadavAkhileshh
Copy link
Owner

@Riyachauhan11 please solve the conflict

@Riyachauhan11
Copy link
Contributor Author

@YadavAkhileshh should be fine now

@Riyachauhan11
Copy link
Contributor Author

@YadavAkhileshh pls review this pr

@YadavAkhileshh YadavAkhileshh merged commit 12cf104 into YadavAkhileshh:main Nov 10, 2024
8 checks passed
@YadavAkhileshh YadavAkhileshh added gssoc-ext New feature or request level2 labels Nov 10, 2024
Copy link

πŸŽ‰πŸŽ‰ Thank you for your contribution! Your PR #731 has been merged! πŸŽ‰πŸŽ‰

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
gssoc-ext New feature or request level2
Projects
None yet
Development

Successfully merging this pull request may close these issues.

BUG: fixing header options and adding footer
2 participants