Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[PC-478] SSE Flux 구현 #41

Merged
merged 8 commits into from
Feb 5, 2025
Merged

[PC-478] SSE Flux 구현 #41

merged 8 commits into from
Feb 5, 2025

Conversation

Lujaec
Copy link
Member

@Lujaec Lujaec commented Feb 3, 2025

🔗 관련 이슈

PC-478

✨ 작업 내용

  • core:sse 모듈 생성
  • SsePersionalService 인터페이스 생성
  • FluxSsePersionalService 구현체 생성
  • sse 연결 API 구현

✅ 체크리스트

  • 코드가 정상적으로 컴파일되나요?
  • 테스트 코드를 통과했나요?
  • merge할 브랜치의 위치를 확인했나요?
  • Label을 지정했나요?

🎃 새롭게 알게된 사항

📋 참고 사항

  • 코드 리뷰 시 논의가 필요한 사항이나 배포 관련 주의 사항을 추가합니다.
    @PreAuthorize(value = "hasRole('USER')")
    이렇게 sse 연결 api에 USER 권한을 가진 회원만 접근가능하도록 설정했는데, 저게 작동을 안 하는 것 같아요.
    Authorization 헤더에 빈 값을 넣고 요청을 보내면 내부에서 userId가 null 이라고 에러를 뱉네요 ,,

@Lujaec Lujaec requested a review from devchlee12 February 3, 2025 12:24
@Lujaec Lujaec self-assigned this Feb 3, 2025
Copy link

github-actions bot commented Feb 3, 2025

Unit Test Results

0 tests   0 ✔️  0s ⏱️
0 suites  0 💤
0 files    0

Results for commit bd24011.

♻️ This comment has been updated with latest results.

@devchlee12
Copy link
Member

Configuration에 메서드 시큐리티 설정이 빠진 것 같습니다.

Copy link
Member

@devchlee12 devchlee12 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

고생하셨습니다.

@Lujaec Lujaec merged commit f2d0413 into develope Feb 5, 2025
1 check failed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants