Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Locally cache emote images for faster load times and reduced load on CDN servers #171

Open
Xzensi opened this issue Sep 29, 2024 · 2 comments
Labels
feature/enhancement New feature or request P2 Medium priority

Comments

@Xzensi
Copy link
Owner

Xzensi commented Sep 29, 2024

No description provided.

@Xzensi Xzensi added feature/enhancement New feature or request P2 Medium priority labels Sep 29, 2024
@cmd430
Copy link

cmd430 commented Sep 30, 2024

I don't think you need to do anything for/about this, browser will only request the emote once for the session then use cache for additional requests of the same emote image as shown here image

ETA: I don't personally use Nipah (I have my own private tweak) but this should be true for Nipah unless you are doing something to invalidate the URLs for emotes (by adding query params for example)

@Xzensi
Copy link
Owner Author

Xzensi commented Sep 30, 2024

I don't think you need to do anything for/about this, browser will only request the emote once for the session then use cache for additional requests of the same emote image as shown here image

ETA: I don't personally use Nipah (I have my own private tweak) but this should be true for Nipah unless you are doing something to invalidate the URLs for emotes (by adding query params for example)

That's certainly true, however on every browser reload it'll have discarded this cache. I can make emote loading nearly instant and at same time further reduce load on CDN's by caching it in CacheStorage as well. The reason for the not-low P2 priority is because I noticed quite a few 7TV CDN degraded service issues with people reporting that 7TV emotes weren't loading, or loading uncomfortably slow. This would at least make it more reliable and stable for when 7TV does have degraded service issues due to high load.

But thinking of lowering priority and focus on other things instead.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
feature/enhancement New feature or request P2 Medium priority
Projects
Status: Ready
Development

No branches or pull requests

2 participants