Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

AIRSplitL2Memref: Disables L2 memref splitting for small designs #745

Open
wants to merge 4 commits into
base: main
Choose a base branch
from

Conversation

erwei-xilinx
Copy link
Collaborator

@erwei-xilinx erwei-xilinx commented Oct 18, 2024

  • Disables the AIRSplitL2Memref pass if none of the air.segments need to map to more than one memtiles.
  • A new option clNumTilesPerL2Tile is added to pass in architecture information: the number of compute tiles with close affinity to one memtile.
  • For example, a column of 4 tiles have close affinity to 1 memtile on NPU.

Copy link
Collaborator

@fifield fifield left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The existing docs say:

Split L2 memref into smaller buffers if it couldn’t fit with the buffer harware constraints

Transforms the input IR by splitting certain L2 memory references (memrefs) to adhere to AIE memtile-specific buffer and DMA channel constraints or optimization opportunities.

and the new option says:

"Number of compute tiles per L2 memory tile. Used to estimate if an air.segment shall allocate to multiple L2 memory tiles, and therefore requires L2 memref splitting."

The existing documentation is pretty vague about when splitting occurs. I can't parse it. The first sentence makes sense, but the rest sounds like a politician's answer. Can you define: "certain L2 memrefs", "memtile-specific buffer and DMA channel constraints", and "optimization opportunities", and how "compute tiles per L2 memory tile" is "Used to estimate" in the context of those other things?

@erwei-xilinx
Copy link
Collaborator Author

The existing docs say:

Thanks for the comment. Agreed that the previous doc was vague and some parts of it are obsolete. I hope that the updated doc better describes the pass.

@fifield
Copy link
Collaborator

fifield commented Oct 18, 2024

The existing docs say:

Thanks for the comment. Agreed that the previous doc was vague and some parts of it are obsolete. I hope that the updated doc better describes the pass.

It is much better, thanks!

@erwei-xilinx erwei-xilinx enabled auto-merge (squash) October 19, 2024 00:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants