Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

CopyToDma: Fold CastOp and ExpandShapeOp into air::DmaMemcpyOp #744

Merged
merged 2 commits into from
Oct 19, 2024

Conversation

erwei-xilinx
Copy link
Collaborator

No description provided.

Copy link
Collaborator

@fifield fifield left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It seems like condenseMemrefDataReorderingToAIRDma is a canonicalization pattern? Should it be implemented as one so that it runs whenever the canonicalilzer runs and not just during this pass? It might also simplify the code to consider each case as a simple canonicalization pattern, instead of as nested if's trying to do the whole thing at once.

@erwei-xilinx
Copy link
Collaborator Author

It seems like condenseMemrefDataReorderingToAIRDma is a canonicalization pattern? Should it be implemented as one so that it runs whenever the canonicalilzer runs and not just during this pass? It might also simplify the code to consider each case as a simple canonicalization pattern, instead of as nested if's trying to do the whole thing at once.

Totally agreed. The lack of such canonicalizer has been creating issues for air.dma_memcpy_nd and air.channel.put/get, as subsequent passes can no longer handle those memref ops. I updated the issue #707 to keep track of this.

@erwei-xilinx erwei-xilinx enabled auto-merge (squash) October 19, 2024 00:52
@erwei-xilinx erwei-xilinx merged commit b5d30a3 into Xilinx:main Oct 19, 2024
11 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants