Ryzen AI Examples #757

jgmelber · 2023-11-14T22:45:57Z

No description provided.

reference_designs/ipu-xrt/edge_detect/Makefile

reference_designs/ipu-xrt/log_hello_world/hello_world.py

reference_designs/ipu-xrt/matrix_multiplication/Makefile

reference_designs/ipu-xrt/matrix_multiplication/run.lit

reference_designs/ipu-xrt/matrix_multiplication/test.cpp

keryell · 2023-11-15T21:41:11Z

reference_designs/ipu-xrt/vision_pipelines/edge_detect/aie2_edgeDetect.py

+from aie.dialects.func import *
+from aie.dialects.scf import *
+from aie.dialects.aie import *
+from aie.dialects.aiex import *


Since this is a teaching exercise, it might be better to avoid these wild-card imports to makes things clear.
Imagine a casual reader not knowing about AIE(X), MLIR, compilation... :-)
At least you could use some namespace shortcut if you dislike spelling aie.dialects.aie. and others all over the place.
For some context, https://peps.python.org/pep-0008

Wildcard imports (from <module> import *) should be avoided, as they make it unclear which names are present in the namespace, confusing both readers and many automated tools. There is one defensible use case for a wildcard import, which is to republish an internal interface as part of a public API (for example, overwriting a pure Python implementation of an interface with the definitions from an optional accelerator module and exactly which definitions will be overwritten isn’t known in advance).

When republishing names this way, the guidelines below regarding public and internal interfaces still apply.

stephenneuendorffer · 2023-11-20T23:41:43Z

When this lands, please make sure that it gets squashed.

jgmelber · 2023-11-20T23:46:42Z

When this lands, please make sure that it gets squashed.

Of course

…meter in the decoder that I need to investigate.

…ctures.

jgmelber · 2023-12-01T22:45:05Z

Looks close. We need a run.lit for log_hello_world and to finish up color detect with a python.

jackl-xilinx · 2023-12-02T07:11:50Z

Looks close. We need a run.lit for log_hello_world and to finish up color detect with a python.

Yeah, we're almost there. I added the remaining missing lit tests but color_threshold and passthrough still need a bit more work to get it working properly.

github-actions · 2023-12-04T23:52:16Z

reference_designs/ipu-xrt/vision_pipelines/color_threshold/test.cpp

+//#define IMAGE_WIDTH_IN 128
+//#define IMAGE_HEIGHT_IN 64


[clang-format] _{reported by reviewdog 🐶}

Suggested change

//#define IMAGE_WIDTH_IN 128

//#define IMAGE_HEIGHT_IN 64

// #define IMAGE_WIDTH_IN 128

// #define IMAGE_HEIGHT_IN 64

github-actions · 2023-12-04T23:52:16Z

reference_designs/ipu-xrt/vision_pipelines/color_threshold/test.cpp

+//#define IMAGE_WIDTH_OUT IMAGE_WIDTH_IN
+//#define IMAGE_HEIGHT_OUT IMAGE_HEIGHT_IN


[clang-format] _{reported by reviewdog 🐶}

Suggested change

//#define IMAGE_WIDTH_OUT IMAGE_WIDTH_IN

//#define IMAGE_HEIGHT_OUT IMAGE_HEIGHT_IN

// #define IMAGE_WIDTH_OUT IMAGE_WIDTH_IN

// #define IMAGE_HEIGHT_OUT IMAGE_HEIGHT_IN

github-actions · 2023-12-04T23:52:16Z

reference_designs/ipu-xrt/vision_pipelines/color_threshold/test.cpp

+//#define IMAGE_AREA_IN (IMAGE_HEIGHT_IN * IMAGE_WIDTH_IN)
+//#define IMAGE_AREA_OUT (IMAGE_HEIGHT_OUT * IMAGE_WIDTH_OUT)


[clang-format] _{reported by reviewdog 🐶}

Suggested change

//#define IMAGE_AREA_IN (IMAGE_HEIGHT_IN * IMAGE_WIDTH_IN)

//#define IMAGE_AREA_OUT (IMAGE_HEIGHT_OUT * IMAGE_WIDTH_OUT)

// #define IMAGE_AREA_IN (IMAGE_HEIGHT_IN * IMAGE_WIDTH_IN)

// #define IMAGE_AREA_OUT (IMAGE_HEIGHT_OUT * IMAGE_WIDTH_OUT)

github-actions · 2023-12-04T23:52:16Z

reference_designs/ipu-xrt/vision_pipelines/color_threshold/test.cpp

+        if (errors < max_errors)
+          std::cout << "Error: " << (uint8_t) * (bufOut + i) << " at " << i
+                    << " should be zero "
+                    << " : input " << std::dec << (uint8_t)srcVec[i] << std::endl;


[clang-format] _{reported by reviewdog 🐶}

Suggested change

<< " : input " << std::dec << (uint8_t)srcVec[i] << std::endl;

<< " : input " << std::dec << (uint8_t)srcVec[i]

<< std::endl;

github-actions · 2023-12-04T23:52:16Z

reference_designs/ipu-xrt/vision_pipelines/color_threshold/test.cpp

+        std::cout << "Below threshold:   " << (uint8_t) * (bufOut + i) << " at " << i
+                  << " is correct "


[clang-format] _{reported by reviewdog 🐶}

Suggested change

std::cout << "Below threshold: " << (uint8_t) * (bufOut + i) << " at " << i

<< " is correct "

std::cout << "Below threshold: " << (uint8_t) * (bufOut + i) << " at "

<< i << " is correct "

github-actions · 2023-12-04T23:52:17Z

reference_designs/ipu-xrt/vision_pipelines/vision_kernels/filter2d.cc

+
+extern "C" {
+
+//#if BIT_WIDTH == 8


[clang-format] _{reported by reviewdog 🐶}

Suggested change

//#if BIT_WIDTH == 8

// #if BIT_WIDTH == 8

github-actions · 2023-12-04T23:52:17Z

reference_designs/ipu-xrt/vision_pipelines/vision_kernels/passThrough.cc

+//
+//===----------------------------------------------------------------------===//
+
+//#define __AIENGINE__ 1


[clang-format] _{reported by reviewdog 🐶}

Suggested change

//#define __AIENGINE__ 1

// #define __AIENGINE__ 1

github-actions · 2023-12-04T23:52:17Z

reference_designs/ipu-xrt/vision_pipelines/vision_kernels/rgba2gray.cc

+                                             const int32_t height,
+                                             const int32_t width) {
+  //::aie::vector<int16_t, 16> WT(66, 129, 25, 128); //Y=0.299*R + 0.587*G +
+  //:0.114*B (BT.470) :aie::vector<int16_t, 16> WT(25, 129, 66, 128);


[clang-format] _{reported by reviewdog 🐶}

Suggested change

//:0.114*B (BT.470) :aie::vector<int16_t, 16> WT(25, 129, 66, 128);

//: 0.114*B (BT.470) :aie::vector<int16_t, 16> WT(25, 129, 66, 128);

github-actions · 2023-12-04T23:52:18Z

reference_designs/ipu-xrt/vision_pipelines/vision_kernels/threshold.cc

+//
+//===----------------------------------------------------------------------===//
+
+//#define __AIENGINE__ 1


[clang-format] _{reported by reviewdog 🐶}

Suggested change

//#define __AIENGINE__ 1

// #define __AIENGINE__ 1

github-actions · 2023-12-04T23:52:18Z

reference_designs/ipu-xrt/vision_pipelines/vision_kernels/threshold.cc

+  XF_THRESHOLD_TYPE_TOZERO_INV = 4,
+};
+
+//#define THRESH_TYPE XF_THRESHOLD_TYPE_BINARY


[clang-format] _{reported by reviewdog 🐶}

Suggested change

//#define THRESH_TYPE XF_THRESHOLD_TYPE_BINARY

// #define THRESH_TYPE XF_THRESHOLD_TYPE_BINARY

github-actions

Remaining comments which cannot be posted as a review comment to avoid GitHub Rate Limit

black

github-actions · 2023-12-04T23:52:23Z

reference_designs/ipu-xrt/add_one_objFifo/aie2.py

+from aie.dialects.extras import memref, arith
+from aie.util import mlir_mod_ctx
+
+def my_add_one_objFifo():


[black] _{reported by reviewdog 🐶}

Suggested change

def my_add_one_objFifo():

def my_add_one_objFifo():

github-actions · 2023-12-04T23:52:24Z

reference_designs/ipu-xrt/add_one_objFifo/aie2.py

+from aie.util import mlir_mod_ctx
+
+def my_add_one_objFifo():
+


[black] _{reported by reviewdog 🐶}

Suggested change

github-actions · 2023-12-04T23:52:24Z

reference_designs/ipu-xrt/add_one_objFifo/aie2.py

+            memRef_16_ty       = T.memref(16, T.i32())
+            memRef_8_ty        = T.memref(8, T.i32())


[black] _{reported by reviewdog 🐶}

Suggested change

memRef_16_ty = T.memref(16, T.i32())

memRef_8_ty = T.memref(8, T.i32())

memRef_16_ty = T.memref(16, T.i32())

memRef_8_ty = T.memref(8, T.i32())

github-actions · 2023-12-04T23:52:24Z

reference_designs/ipu-xrt/add_one_objFifo/aie2.py

+            memRef_16_ty       = T.memref(16, T.i32())
+            memRef_8_ty        = T.memref(8, T.i32())
+            ofifo_memRef_16_ty = TypeAttr.get(ObjectFifoType.get(memRef_16_ty))
+            ofifo_memRef_8_ty  = TypeAttr.get(ObjectFifoType.get(memRef_8_ty))


[black] _{reported by reviewdog 🐶}

Suggested change

ofifo_memRef_8_ty = TypeAttr.get(ObjectFifoType.get(memRef_8_ty))

ofifo_memRef_8_ty = TypeAttr.get(ObjectFifoType.get(memRef_8_ty))

github-actions · 2023-12-04T23:52:24Z

reference_designs/ipu-xrt/add_one_objFifo/aie2.py

+            ShimTile     = tile(0, 0)
+            MemTile      = tile(0, 1)


[black] _{reported by reviewdog 🐶}

Suggested change

ShimTile = tile(0, 0)

MemTile = tile(0, 1)

ShimTile = tile(0, 0)

MemTile = tile(0, 1)

github-actions · 2023-12-04T23:52:26Z

reference_designs/ipu-xrt/matrix_multiplication/aie2.py

+            ShimTile     = tile(0, 0)
+            MemTile      = tile(0, 1)


[black] _{reported by reviewdog 🐶}

Suggested change

ShimTile = tile(0, 0)

MemTile = tile(0, 1)

ShimTile = tile(0, 0)

MemTile = tile(0, 1)

github-actions · 2023-12-04T23:52:26Z

reference_designs/ipu-xrt/matrix_multiplication/aie2.py

+            objectfifo("memA", MemTile, [ComputeTile2], 2, ofifo_memRef_A_ty,
+                                        [(m//r, r*k*word_size_in//4), 
+                                        (k//s, s*word_size_in//4), 
+                                        (r, k*word_size_in//4), 
+                                        (s*word_size_in//4, 1)], [])


[black] _{reported by reviewdog 🐶}

Suggested change

objectfifo("memA", MemTile, [ComputeTile2], 2, ofifo_memRef_A_ty,

[(m//r, r*k*word_size_in//4),

(k//s, s*word_size_in//4),

(r, k*word_size_in//4),

(s*word_size_in//4, 1)], [])

objectfifo(

"memA",

MemTile,

[ComputeTile2],

2,

ofifo_memRef_A_ty,

[

(m // r, r * k * word_size_in // 4),

(k // s, s * word_size_in // 4),

(r, k * word_size_in // 4),

(s * word_size_in // 4, 1),

],

[],

)

github-actions · 2023-12-04T23:52:26Z

reference_designs/ipu-xrt/matrix_multiplication/aie2.py

+            objectfifo("memB", MemTile, [ComputeTile2], 2, ofifo_memRef_B_ty,
+                                        [(k//s, s*n*word_size_in//4), 
+                                        (n//t, t*word_size_in//4), 
+                                        (s, n*word_size_in//4), 
+                                        (t*word_size_in//4, 1)], [])


[black] _{reported by reviewdog 🐶}

Suggested change

objectfifo("memB", MemTile, [ComputeTile2], 2, ofifo_memRef_B_ty,

[(k//s, s*n*word_size_in//4),

(n//t, t*word_size_in//4),

(s, n*word_size_in//4),

(t*word_size_in//4, 1)], [])

objectfifo(

"memB",

MemTile,

[ComputeTile2],

2,

ofifo_memRef_B_ty,

[

(k // s, s * n * word_size_in // 4),

(n // t, t * word_size_in // 4),

(s, n * word_size_in // 4),

(t * word_size_in // 4, 1),

],

[],

)

github-actions · 2023-12-04T23:52:26Z

reference_designs/ipu-xrt/matrix_multiplication/aie2.py

+            objectfifo("outC", MemTile, [ShimTile], 2, ofifo_memRef_C_ty,
+                                        [(m//r, r*n*word_size_out//4), 
+                                        (r, t*word_size_out//4), 
+                                        (n//t, r*t*word_size_out//4), 
+                                        (t*word_size_out//4, 1)], [])


[black] _{reported by reviewdog 🐶}

Suggested change

objectfifo("outC", MemTile, [ShimTile], 2, ofifo_memRef_C_ty,

[(m//r, r*n*word_size_out//4),

(r, t*word_size_out//4),

(n//t, r*t*word_size_out//4),

(t*word_size_out//4, 1)], [])

objectfifo(

"outC",

MemTile,

[ShimTile],

2,

ofifo_memRef_C_ty,

[

(m // r, r * n * word_size_out // 4),

(r, t * word_size_out // 4),

(n // t, r * t * word_size_out // 4),

(t * word_size_out // 4, 1),

],

[],

)

github-actions · 2023-12-04T23:52:26Z

reference_designs/ipu-xrt/matrix_multiplication/aie2.py

+            objectfifo_link(["memC"], ["outC"])
+
+            # Set up compute tiles
+


[black] _{reported by reviewdog 🐶}

Suggested change

github-actions

Remaining comments which cannot be posted as a review comment to avoid GitHub Rate Limit

black

github-actions · 2023-12-05T00:01:35Z

reference_designs/ipu-xrt/matrix_multiplication/aie2.py

+
+    print(ctx.module)
+
+my_matmul()


[black] _{reported by reviewdog 🐶}

Suggested change

my_matmul()

my_matmul()

github-actions · 2023-12-05T00:01:35Z

reference_designs/ipu-xrt/passthrough_hardware/aie2.py

+if len(sys.argv) == 2:
+    N = int(sys.argv[1])
+
+def my_passthrough():


[black] _{reported by reviewdog 🐶}

Suggested change

def my_passthrough():

github-actions · 2023-12-05T00:01:35Z

reference_designs/ipu-xrt/passthrough_hardware/aie2.py

+
+def my_passthrough():
+
+    with mlir_mod_ctx() as ctx:


[black] _{reported by reviewdog 🐶}

Suggested change

with mlir_mod_ctx() as ctx:

def my_passthrough():

with mlir_mod_ctx() as ctx:

github-actions · 2023-12-05T00:01:35Z

reference_designs/ipu-xrt/passthrough_hardware/aie2.py

+
+        @device(AIEDevice.ipu)
+        def device_body():
+            memRef_ty       = T.memref(1024, T.i32())


[black] _{reported by reviewdog 🐶}

Suggested change

memRef_ty = T.memref(1024, T.i32())

memRef_ty = T.memref(1024, T.i32())

github-actions · 2023-12-05T00:01:36Z

reference_designs/ipu-xrt/passthrough_hardware/aie2.py

+            ofifo_memRef_ty = TypeAttr.get(ObjectFifoType.get(memRef_ty))
+
+            # Tile declarations
+            ShimTile     = tile(0, 0)


[black] _{reported by reviewdog 🐶}

Suggested change

ShimTile = tile(0, 0)

ShimTile = tile(0, 0)

github-actions · 2023-12-05T00:01:38Z

reference_designs/ipu-xrt/vision_pipelines/color_threshold/aie2_colorThreshold.py

+            ShimTile     = tile(0, 0)
+            MemTile      = tile(0, 1)


[black] _{reported by reviewdog 🐶}

Suggested change

ShimTile = tile(0, 0)

MemTile = tile(0, 1)

ShimTile = tile(0, 0)

MemTile = tile(0, 1)

github-actions · 2023-12-05T00:01:38Z

reference_designs/ipu-xrt/vision_pipelines/color_threshold/aie2_colorThreshold.py

+            objectfifo("inOOB_L3L2", ShimTile, [MemTile], 2, ofifo_line_channels_ty, [], [])
+            objectfifo("inOOB_L2L1_0", MemTile, [ComputeTile2], 2, ofifo_line_ty, [], [])
+            objectfifo("inOOB_L2L1_1", MemTile, [ComputeTile3], 2, ofifo_line_ty, [], [])
+            objectfifo("inOOB_L2L1_2", MemTile, [ComputeTile4], 2, ofifo_line_ty, [], [])
+            objectfifo("inOOB_L2L1_3", MemTile, [ComputeTile5], 2, ofifo_line_ty, [], [])
+            objectfifo_link(["inOOB_L3L2"], ["inOOB_L2L1_0", "inOOB_L2L1_1", "inOOB_L2L1_2", "inOOB_L2L1_3"])
+
+            # Output RGBA 
+            objectfifo("outOOB_L2L3", MemTile, [ShimTile], 2, ofifo_line_channels_ty, [], [])
+            objectfifo("outOOB_L1L2_0", ComputeTile2, [MemTile], 2, ofifo_line_ty, [], [])
+            objectfifo("outOOB_L1L2_1", ComputeTile3, [MemTile], 2, ofifo_line_ty, [], [])
+            objectfifo("outOOB_L1L2_2", ComputeTile4, [MemTile], 2, ofifo_line_ty, [], [])
+            objectfifo("outOOB_L1L2_3", ComputeTile5, [MemTile], 2, ofifo_line_ty, [], [])
+            objectfifo_link(["outOOB_L1L2_0", "outOOB_L1L2_1", "outOOB_L1L2_2", "outOOB_L1L2_3"], ["outOOB_L2L3"])


[black] _{reported by reviewdog 🐶}

Suggested change

objectfifo("inOOB_L3L2", ShimTile, [MemTile], 2, ofifo_line_channels_ty, [], [])

objectfifo("inOOB_L2L1_0", MemTile, [ComputeTile2], 2, ofifo_line_ty, [], [])

objectfifo("inOOB_L2L1_1", MemTile, [ComputeTile3], 2, ofifo_line_ty, [], [])

objectfifo("inOOB_L2L1_2", MemTile, [ComputeTile4], 2, ofifo_line_ty, [], [])

objectfifo("inOOB_L2L1_3", MemTile, [ComputeTile5], 2, ofifo_line_ty, [], [])

objectfifo_link(["inOOB_L3L2"], ["inOOB_L2L1_0", "inOOB_L2L1_1", "inOOB_L2L1_2", "inOOB_L2L1_3"])

# Output RGBA

objectfifo("outOOB_L2L3", MemTile, [ShimTile], 2, ofifo_line_channels_ty, [], [])

objectfifo("outOOB_L1L2_0", ComputeTile2, [MemTile], 2, ofifo_line_ty, [], [])

objectfifo("outOOB_L1L2_1", ComputeTile3, [MemTile], 2, ofifo_line_ty, [], [])

objectfifo("outOOB_L1L2_2", ComputeTile4, [MemTile], 2, ofifo_line_ty, [], [])

objectfifo("outOOB_L1L2_3", ComputeTile5, [MemTile], 2, ofifo_line_ty, [], [])

objectfifo_link(["outOOB_L1L2_0", "outOOB_L1L2_1", "outOOB_L1L2_2", "outOOB_L1L2_3"], ["outOOB_L2L3"])

objectfifo(

"inOOB_L3L2", ShimTile, [MemTile], 2, ofifo_line_channels_ty, [], []

)

objectfifo(

"inOOB_L2L1_0", MemTile, [ComputeTile2], 2, ofifo_line_ty, [], []

)

objectfifo(

"inOOB_L2L1_1", MemTile, [ComputeTile3], 2, ofifo_line_ty, [], []

)

objectfifo(

"inOOB_L2L1_2", MemTile, [ComputeTile4], 2, ofifo_line_ty, [], []

)

objectfifo(

"inOOB_L2L1_3", MemTile, [ComputeTile5], 2, ofifo_line_ty, [], []

)

objectfifo_link(

["inOOB_L3L2"],

["inOOB_L2L1_0", "inOOB_L2L1_1", "inOOB_L2L1_2", "inOOB_L2L1_3"],

)

# Output RGBA

objectfifo(

"outOOB_L2L3", MemTile, [ShimTile], 2, ofifo_line_channels_ty, [], []

)

objectfifo(

"outOOB_L1L2_0", ComputeTile2, [MemTile], 2, ofifo_line_ty, [], []

)

objectfifo(

"outOOB_L1L2_1", ComputeTile3, [MemTile], 2, ofifo_line_ty, [], []

)

objectfifo(

"outOOB_L1L2_2", ComputeTile4, [MemTile], 2, ofifo_line_ty, [], []

)

objectfifo(

"outOOB_L1L2_3", ComputeTile5, [MemTile], 2, ofifo_line_ty, [], []

)

objectfifo_link(

["outOOB_L1L2_0", "outOOB_L1L2_1", "outOOB_L1L2_2", "outOOB_L1L2_3"],

["outOOB_L2L3"],

)

github-actions · 2023-12-05T00:01:38Z

reference_designs/ipu-xrt/vision_pipelines/color_threshold/aie2_colorThreshold.py

+            rtpComputeTile3 = Buffer(ComputeTile3, [16], T.i32(), "rtpComputeTile3")
+            rtpComputeTile4 = Buffer(ComputeTile4, [16], T.i32(), "rtpComputeTile4")
+            rtpComputeTile5 = Buffer(ComputeTile5, [16], T.i32(), "rtpComputeTile5")
+


[black] _{reported by reviewdog 🐶}

Suggested change

github-actions · 2023-12-05T00:01:38Z

reference_designs/ipu-xrt/vision_pipelines/color_threshold/aie2_colorThreshold.py

+            rtpComputeTile5 = Buffer(ComputeTile5, [16], T.i32(), "rtpComputeTile5")
+
+            # Set up compute tiles
+


[black] _{reported by reviewdog 🐶}

Suggested change

github-actions · 2023-12-05T00:01:38Z

reference_designs/ipu-xrt/vision_pipelines/color_threshold/aie2_colorThreshold.py

+                # thresholdValue = arith.trunci(T.i16(), memref.load(rtpComputeTile2, [0]))
+                # maxValue       = arith.trunci(T.i16(), memref.load(rtpComputeTile2, [1]))
+                # thresholdType  = arith.trunci(T.i8(),  memref.load(rtpComputeTile2, [2]))
+                maxValue       = arith.constant(255, T.i16())


[black] _{reported by reviewdog 🐶}

Suggested change

maxValue = arith.constant(255, T.i16())

maxValue = arith.constant(255, T.i16())

makslevental · 2023-12-05T00:07:06Z

@jackl-xilinx you need to run black formatter on all of the python files (pip install black && black reference_designs).

…xamples2

denolf

Thanks for wrapping this up @jackl-xilinx.

jgmelber · 2023-12-05T15:49:20Z

@makslevental can we ignore this directory in the clang-tidy check: reference_designs/ipu-xrt/vision_pipelines/vision_kernels ?

jgmelber mentioned this pull request Nov 14, 2023

Ryzen AI Examples #753

Closed

jgmelber force-pushed the examples2 branch from 5e7c9fa to 6bd95b9 Compare November 15, 2023 00:06

keryell reviewed Nov 15, 2023

View reviewed changes

jgmelber force-pushed the examples2 branch from c38cc54 to b877650 Compare November 15, 2023 05:57

keryell reviewed Nov 15, 2023

View reviewed changes

jgmelber force-pushed the examples2 branch 2 times, most recently from 7c85558 to 3c5dfd2 Compare November 16, 2023 18:26

denolf mentioned this pull request Nov 22, 2023

Color detect #777

Merged

STFleming and others added 20 commits November 28, 2023 13:33

Initial hello world PoC example up, some issues with more than 1 para…

588a69a

…meter in the decoder that I need to investigate.

Added small README for simple printf example reference design

d2b9242

Add python bindings

b0fd7ce

Add ipu examples

bcb3f6f

Move hello_world

1bacb7e

Added 1080p py

1407ef4

Fixed tensorSize naming

e670430

Updated python code to new bindings.

260b632

Fix test.cpp

1057628

move to prepare for more vision pipelines

1110d5a

Initial edge detect and vision kernel source commit

7734ee6

Moved vision kernels

7bd1f2a

adding CMake win build support

b51fa43

Removed 720 and tiny designs

60968e4

adding passThrough

1bbd760

8k variant passThrough

0af7f40

move to prepare fore merge

4c36d31

Updated edge_detect python designs

03cfc51

fix path

6ab3b3d

consistency

405dc03

abisca and others added 7 commits December 1, 2023 04:26

Pull in main branch

dc7e67b

Fix merge conflicts with examples2

71b1633

Add README for passThrough

8e9370c

Update READMEs for add_one_objFifo, edge_detect, color_detect. Add pi…

beb2525

…ctures.

Fix lingering merge conflicts

9479f90

Clang format and remove

c14047e

Merge branch 'main' into examples2

671eac6

jackl-xilinx added 2 commits December 1, 2023 22:56

Update vision_pipeline designs to new python syntax and added lit tests

73b7d3d

Resolve merge conflict.

a456343

jackl-xilinx added 3 commits December 1, 2023 23:18

Clang format cleanup.

3865fa1

Fixed passthrough error and cleaned up py source

9a0497c

Fixed color threshold and added comments to python source

643327d

github-actions bot reviewed Dec 4, 2023

View reviewed changes

Merge branch 'main' into examples2

b33b7df

github-actions bot reviewed Dec 5, 2023

View reviewed changes

jackl-xilinx requested a review from denolf December 5, 2023 00:06

jackl-xilinx and others added 4 commits December 4, 2023 16:18

Run black to fix py format

74ce95c

Merge branch 'main' into examples2

4dd3f21

Fixed clang format errors

a9571cc

Merge branch 'examples2' of https://github.com/Xilinx/mlir-aie into e…

4028de1

…xamples2

jackl-xilinx marked this pull request as ready for review December 5, 2023 00:49

Merge branch 'main' into examples2

beb7678

denolf approved these changes Dec 5, 2023

View reviewed changes

jackl-xilinx merged commit b6016fd into main Dec 5, 2023
6 of 7 checks passed

makslevental deleted the examples2 branch December 7, 2023 17:08

		//#define IMAGE_WIDTH_OUT IMAGE_WIDTH_IN
		//#define IMAGE_HEIGHT_OUT IMAGE_HEIGHT_IN

		//#define IMAGE_AREA_IN (IMAGE_HEIGHT_IN * IMAGE_WIDTH_IN)
		//#define IMAGE_AREA_OUT (IMAGE_HEIGHT_OUT * IMAGE_WIDTH_OUT)

	<< " : input " << std::dec << (uint8_t)srcVec[i] << std::endl;
	<< " : input " << std::dec << (uint8_t)srcVec[i]
	<< std::endl;

		std::cout << "Below threshold: " << (uint8_t) * (bufOut + i) << " at " << i
		<< " is correct "

	//:0.114*B (BT.470) :aie::vector<int16_t, 16> WT(25, 129, 66, 128);
	//: 0.114*B (BT.470) :aie::vector<int16_t, 16> WT(25, 129, 66, 128);

	//#define THRESH_TYPE XF_THRESHOLD_TYPE_BINARY
	// #define THRESH_TYPE XF_THRESHOLD_TYPE_BINARY

		memRef_16_ty = T.memref(16, T.i32())
		memRef_8_ty = T.memref(8, T.i32())

	ofifo_memRef_8_ty = TypeAttr.get(ObjectFifoType.get(memRef_8_ty))
	ofifo_memRef_8_ty = TypeAttr.get(ObjectFifoType.get(memRef_8_ty))

	with mlir_mod_ctx() as ctx:
	def my_passthrough():
	with mlir_mod_ctx() as ctx:

	memRef_ty = T.memref(1024, T.i32())
	memRef_ty = T.memref(1024, T.i32())

		rtpComputeTile5 = Buffer(ComputeTile5, [16], T.i32(), "rtpComputeTile5")

		# Set up compute tiles

	maxValue = arith.constant(255, T.i16())
	maxValue = arith.constant(255, T.i16())

Ryzen AI Examples #757

Ryzen AI Examples #757

Conversation

jgmelber commented Nov 14, 2023

keryell Nov 15, 2023 • edited Loading

Choose a reason for hiding this comment

stephenneuendorffer commented Nov 20, 2023

jgmelber commented Nov 20, 2023

jgmelber commented Dec 1, 2023

jackl-xilinx commented Dec 2, 2023

github-actions bot Dec 4, 2023

Choose a reason for hiding this comment

github-actions bot Dec 4, 2023

Choose a reason for hiding this comment

github-actions bot Dec 4, 2023

Choose a reason for hiding this comment

github-actions bot Dec 4, 2023

Choose a reason for hiding this comment

github-actions bot Dec 4, 2023

Choose a reason for hiding this comment

github-actions bot Dec 4, 2023

Choose a reason for hiding this comment

github-actions bot Dec 4, 2023

Choose a reason for hiding this comment

github-actions bot Dec 4, 2023

Choose a reason for hiding this comment

github-actions bot Dec 4, 2023

Choose a reason for hiding this comment

github-actions bot Dec 4, 2023

Choose a reason for hiding this comment

github-actions bot left a comment

Choose a reason for hiding this comment

github-actions bot Dec 4, 2023

Choose a reason for hiding this comment

github-actions bot Dec 4, 2023

Choose a reason for hiding this comment

github-actions bot Dec 4, 2023

Choose a reason for hiding this comment

github-actions bot Dec 4, 2023

Choose a reason for hiding this comment

github-actions bot Dec 4, 2023

Choose a reason for hiding this comment

github-actions bot Dec 4, 2023

Choose a reason for hiding this comment

github-actions bot Dec 4, 2023

Choose a reason for hiding this comment

github-actions bot Dec 4, 2023

Choose a reason for hiding this comment

github-actions bot Dec 4, 2023

Choose a reason for hiding this comment

github-actions bot Dec 4, 2023

Choose a reason for hiding this comment

github-actions bot left a comment

Choose a reason for hiding this comment

github-actions bot Dec 5, 2023

Choose a reason for hiding this comment

github-actions bot Dec 5, 2023

Choose a reason for hiding this comment

github-actions bot Dec 5, 2023

Choose a reason for hiding this comment

github-actions bot Dec 5, 2023

Choose a reason for hiding this comment

github-actions bot Dec 5, 2023

Choose a reason for hiding this comment

github-actions bot Dec 5, 2023

Choose a reason for hiding this comment

github-actions bot Dec 5, 2023

Choose a reason for hiding this comment

github-actions bot Dec 5, 2023

Choose a reason for hiding this comment

github-actions bot Dec 5, 2023

Choose a reason for hiding this comment

github-actions bot Dec 5, 2023

Choose a reason for hiding this comment

makslevental commented Dec 5, 2023 • edited Loading

denolf left a comment

Choose a reason for hiding this comment

jgmelber commented Dec 5, 2023 • edited Loading

keryell Nov 15, 2023 •

edited

Loading

makslevental commented Dec 5, 2023 •

edited

Loading

jgmelber commented Dec 5, 2023 •

edited

Loading