[aievec] Make transpose lowering more progressive #1574
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jamestcl-amd
approved these changes
Jun 21, 2024
| return failure(); | ||
|
|
||
| rewriter.replaceOpWithNewOp<aievec::ShuffleOp>( | ||
| transpOp, resVecTy, adaptor.getMatrix(), nullptr, shuffleMode); |
There was a problem hiding this comment.
operand name is matrix, interesting.
| @@ -2880,6 +2880,67 @@ struct LowerVectorTransposeOpToAIEVecShuffleOpPattern | |||
| } | |||
| }; | |||
|
|
|||
| // Convert a `vector.flat_transpose` op to an `aievec.shuffle` op for AIEml. | |||
| struct LowerVectorFlatTransposeOpToAIEVecShuffleOpPattern | |||
There was a problem hiding this comment.
We can probably remove the old pattern LowerVectorTransposeOpToAIEVecShuffleOpPattern in the future, to reduce the maintenance cost.
| @@ -562,6 +562,54 @@ struct ExtractTransposeFromContractionOp | |||
| } | |||
| }; | |||
|
|
|||
| // This pattern flattens a `vector.transpose` operation for shapes that can be | |||
| // handled by basic AIE shuffle ops. | |||
| struct FlattenVectorTransposeOpPattern | |||
There was a problem hiding this comment.
Can we add a separate lit test for this pattern? Thanks!
jsetoain
force-pushed
the
lower-transpose-through-flat-transpose
branch
from
993340c
to
7aecaa5
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.