This repository has been archived by the owner on Jun 23, 2022. It is now read-only.
CMake: remove MY_PROJ_LIB_PATH #285
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
vagetablechicken
requested review from
neverchanje,
acelyc111,
hycdong,
mentoswang,
qinzuoyan,
foreverneverer and
zhangyifan27
neverchanje
reviewed
Jul 30, 2019
neverchanje
approved these changes
Jul 30, 2019
|
qinzuoyan
approved these changes
Aug 8, 2019
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
apache/incubator-pegasus#361 (comment)
移除MY_PROJ_LIB_PATH，对rdsn不会有影响，因为setup()中的
link_directories(${DSN_THIRDPARTY_ROOT}/lib)保证了第三方库可以被找到。但是link_directories也有问题，后续会将其删除。