Skip to content
This repository has been archived by the owner on Jun 23, 2022. It is now read-only.

*: remove DSN_IN_CORE, improve BOOST linking, fix build.sh #283

Merged
merged 6 commits into from
Jul 29, 2019
Merged

*: remove DSN_IN_CORE, improve BOOST linking, fix build.sh #283

merged 6 commits into from
Jul 29, 2019

Conversation

vagetablechicken
Copy link
Member

huangwei5 added 4 commits July 25, 2019 16:58
remove DSN_BUILD_RUNTIME & DSN_IN_CORE
c89d2d9
cmake: remove MY_BOOST_PACKAGES
33b034e 
Use MY_BOOST_LIBS temporarily, cause dsn_runtime depends on boost libs.
We will create implicit dependencies between dsn_runtime and boost libs
in the future so we will no longer add boost libs explicitly when
linking dsn_runtime.
CMake mininum version increase to 3.5.2
3e839ba
fix getting DSN_GIT_COMMIT
fbc687a
@vagetablechicken vagetablechicken changed the title CMakeList: remove DSN_IN_CORE & improve BOOST linking remove DSN_IN_CORE, improve BOOST linking, fix build.sh Jul 26, 2019
@vagetablechicken vagetablechicken changed the title remove DSN_IN_CORE, improve BOOST linking, fix build.sh *: remove DSN_IN_CORE, improve BOOST linking, fix build.sh Jul 26, 2019
@vagetablechicken vagetablechicken marked this pull request as ready for review July 26, 2019 08:09
neverchanje
neverchanje reviewed Jul 27, 2019
View reviewed changes
Copy link
Contributor

@neverchanje neverchanje left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

给个建议：

  • 后面 fmt 希望跟 thrift 一样作为默认链接。
  • dsn_runtime 看看能不能直接编译成一个库，不要用那种 object 拼起来的方式
  • dsn_replica_server 和 dsn_meta_server 看看能不能做成静态库，项目统一用一种方式，有必要的时候再用 "BUILD_SHARED_LIBS=ON" 做动态库。

另外就是起一个新的 PR，把 dsn.cmake 里面好多 remove this 都删了把

@neverchanje neverchanje added area/installation PR or issues related to compilation / build scripts / installation / deployment. component/scripts labels Jul 27, 2019
@vagetablechicken
Copy link
Member Author

vagetablechicken commented Jul 27, 2019 •
edited
Loading

给个建议：

  • 后面 fmt 希望跟 thrift 一样作为默认链接。
  • dsn_runtime 看看能不能直接编译成一个库，不要用那种 object 拼起来的方式
  • dsn_replica_server 和 dsn_meta_server 看看能不能做成静态库，项目统一用一种方式，有必要的时候再用 "BUILD_SHARED_LIBS=ON" 做动态库。

另外就是起一个新的 PR，把 dsn.cmake 里面好多 remove this 都删了把

  1. fmt作为默认链接，后面会改的。身份认证进来后，core里也需要fmt了，搞成默认的更简单。在处理idl: replace bin/Linux/thrift with official thrift compiler #190 的时候一起吧。
  2. dsn_runtime已经是静态库了，关键是符号不全，使用dsn_runtime时还得补上相关的库，这个我会尝试修下，但有点困难，所以放在计划的后期。最终目标是dsn_runtime可以被单独使用，不需要附加链接。
  3. 做成静态库这个，我记下，后面调研下。
  4. 另开pr清理dsn.cmake的remove，OK

@neverchanje neverchanje merged commit 7c1ecf5 into XiaoMi:master Jul 29, 2019
@vagetablechicken vagetablechicken deleted the dsn_in_core branch July 30, 2019 02:35
@neverchanje neverchanje removed area/installation PR or issues related to compilation / build scripts / installation / deployment. component/scripts labels Oct 11, 2019
@neverchanje neverchanje mentioned this pull request Oct 25, 2019
Closed
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@neverchanje neverchanje neverchanje approved these changes

@hycdong hycdong hycdong approved these changes

@qinzuoyan qinzuoyan Awaiting requested review from qinzuoyan

@acelyc111 acelyc111 Awaiting requested review from acelyc111

@mentoswang mentoswang Awaiting requested review from mentoswang

@foreverneverer foreverneverer Awaiting requested review from foreverneverer

@zhangyifan27 zhangyifan27 Awaiting requested review from zhangyifan27

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@vagetablechicken @neverchanje @hycdong