Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Feature Request] Don't save at every step #7

Open
ljleb opened this issue Mar 8, 2023 · 2 comments
Open

[Feature Request] Don't save at every step #7

ljleb opened this issue Mar 8, 2023 · 2 comments

Comments

@ljleb
Copy link

ljleb commented Mar 8, 2023

Correct me if I'm wrong, but saving a checkpoint on disk at every step of adjusting merge ratios slows down the learning process by a lot IIUC. I think every n iterations should be treated as an epoch, i.e. it should be possible to save multiple models over time, but only save one intermediate model after a specified number of iterations.

Is it okay with you if I open a PR for this? Not sure how long I'll take as I'm unfamiliar with the repo.

@Xerxemi
Copy link
Owner

Xerxemi commented Mar 8, 2023

You're right about that, but actually, it saves the model to disk to be able to use it to generate but doesn't keep it, it's a limitation of the current code. Xynon is looking into swapping the testing backend for either runtime's or supermerger's but both of us are pretty busy rn (both aformentioned are different codebases so will take a while to integrate) and as such there is no eta.

Saving models as epochs wouldn't be useful, as all past final and test merges are saved to history tsvs already.

@ljleb
Copy link
Author

ljleb commented Mar 8, 2023

Ah makes sense, as we know the original models we only need to save the receipe. simple and effective.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants