Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Don't stop if pushbuffer is finished #9

Open
JayFoxRox opened this issue Jun 27, 2018 · 0 comments
Open

Don't stop if pushbuffer is finished #9

JayFoxRox opened this issue Jun 27, 2018 · 0 comments

Comments

@JayFoxRox
Copy link
Member

The original design assumed that pushbuffers would eventually finish. However, in reality, the pushbuffers typically never stop running, as there's always new data queued already.
I then decided to implement continous tracing (which is also more useful), but the old stop logic remains.

I'm not sure which changes would be necessary to detect a restart.
I worry that this might break our current tracing logic. Also see #7

@JayFoxRox JayFoxRox changed the title Don't stop if trace is finished Don't stop if pushbuffer is finished Jun 27, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

No branches or pull requests

1 participant