Preliminary review only, do not merge - first stab at required prop utiltities #859
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Security InsightsNo security relevant content was detected by automated scans. Action Items
Questions or Comments? Reach out on Slack: #support-infosec. |
greglittlefield-wf
changed the title
greglittlefield-wf
force-pushed
the
null-safety-required-props
branch
2 times, most recently
from
8c62d49 to
134f4d5
Compare
greglittlefield-wf
changed the base branch from
null-safety-update-lints
to
v5_wip
greglittlefield-wf
force-pushed
the
null-safety-required-props
branch
from
37d21a8 to
5476c20
Compare
…BoundaryPropsMapView
greglittlefield-wf
force-pushed
the
null-safety-required-props
branch
from
5476c20 to
42266a6
Compare
greglittlefield-wf
force-pushed
the
null-safety-required-props
branch
from
2b9004e to
481269f
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We need some utilities to be able to safely access required props.
See example/builder/src/partial.dart for an example.
To help keep these APIs ergonomic, a new extension method
UiProps.getPropKeywas added, which required some generation changes. Without that API, consumers would have to also pass in the factory associated with the props.