-
Notifications
You must be signed in to change notification settings - Fork 30
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add Swag page template and pattern #448
Conversation
Code-wise, fine. I think it could use better copy treatment though. People looking for swag will be disappointed. cc @WordPress/meta-design @thetinyl @DanSoschin |
The challenge here is that there are likely many questions ... to which I have no answers... e.g. Will it reopen? If so, when? Why did it close? Where can I get more information? Should I check back later? Etc. All I know is that it's closed indefinitely and there doesn't seem like a lot of urgency to replace it with something. I have a few ideas, but again, it doesn't seem like a priority currently. |
We could elaborate slightly: Thank you for visiting the swag store. Unfortunately, the swag store is currently closed until further notice. There is no current timeline for reopening, but you can check back here for updates or follow WordPress on social media where any announcements will be made. |
This is the big challenge of the day, for sure.
I agree with @StevenDufresne that leaving it at "The store is closed." feels very abrupt and doesn't answer anything, but I'm also wary of inviting folks to hope or "check back here" when there isn't any real plan in place to reboot Mercantile at the moment (as per @DanSoschin's suggestion). I wonder though... are there still avenues to get swag that aren't the Mercantile? Will WordCamps/meetups still have swag? If so, this could be an opportunity to cross-promote events instead. Then it's less of a dead end. Example:
|
Plus one to Lauren's copy. There is swag at most WordCamps, though it's not a given. I love the idea of cross-promoting events. |
LOVE IT
…On Wed, Jun 5, 2024 at 5:09 PM Adam Wood ***@***.***> wrote:
Content updated, how does this look?
Screenshot.2024-06-06.at.9.07.59.AM.jpg (view on web)
<https://github.com/WordPress/wporg-main-2022/assets/1017872/c190db51-cc15-4b5b-ae13-25adbc8b67c2>
—
Reply to this email directly, view it on GitHub
<#448 (comment)>,
or unsubscribe
<https://github.com/notifications/unsubscribe-auth/AMV2M4HUWGY64HTOZ3BNLT3ZF55BHAVCNFSM6AAAAABIZOJLV2VHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMZDCNJQHE3DMOBZGM>
.
You are receiving this because you were mentioned.Message ID:
***@***.***>
--
Dan Soschin | Marketing
.org Division
+1 813.731.6078
Tampa, Florida, USA
@DanSoschin
|
Thanks for the overnight conversation. To your suggestion, Adam, and coming back to this, I'm more drawn to the much smaller and more muted h6-size heading, with no borders, this one. I still feel like we should reduce the text—"for now" feels like plenty of context to me—but Laurens copy is better! |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The content renders well 👍
Just a PHPCS suggestion.
<!-- /wp:heading --> | ||
|
||
<!-- wp:paragraph --> | ||
<p><?php _e( 'The Mercantile: WordPress Swag Store has closed its doors for now. Thanks for always wearing your love of WordPress for all to see, and for supporting the WordPress Foundation.', 'wporg' ); ?></p> |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Saw the warning suggesting changing to esc_html_e()
All output should be run through an escaping function (like esc_html_e() or esc_attr_e()), found '_e'.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This was probably generated with the sync script, which uses _e()
. If we wanted to escape it, we would need to figure out the context of the strings to know if we need esc_html_e, esc_attr_e, esc_url_e, or wp_kses (for strings with HTML). I don't think it's too big of an issue here.
See comment.
We have a redirect in place for
/about/swag
to the mercantile store, but now that the store is shut that redirect is being removed and we need a landing page again.Screenshots