Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add Swag page template and pattern #448

Merged
merged 3 commits into from
Jun 6, 2024
Merged

Add Swag page template and pattern #448

merged 3 commits into from
Jun 6, 2024

Conversation

adamwoodnz
Copy link
Contributor

@adamwoodnz adamwoodnz commented Jun 4, 2024

See comment.

We have a redirect in place for /about/swag to the mercantile store, but now that the store is shut that redirect is being removed and we need a landing page again.

Screenshots

localhost_8888_about_swag_(Desktop)

@adamwoodnz adamwoodnz added the [Component] Content Bugs or issues related to the page content label Jun 4, 2024
@adamwoodnz adamwoodnz self-assigned this Jun 4, 2024
@StevenDufresne
Copy link
Contributor

Code-wise, fine. I think it could use better copy treatment though. People looking for swag will be disappointed.

cc @WordPress/meta-design @thetinyl @DanSoschin

@jasmussen
Copy link
Contributor

jasmussen commented Jun 5, 2024

A slew of options.

Swag closed light
Swag closed light alt
Swag closed alt
Swag closed

I don't particularly like any of them. Perhaps these two:

Swag closed inter

Swag closed light inter

I don't think we need to be that verbose in the text. "currently" implies it's situational. No strong opinion, but let's make sure we don't link to this store from anywhere, so you'd only land on this if you search. Do we want it no-indexed, or would it be a waste?

@DanSoschin
Copy link

The challenge here is that there are likely many questions ... to which I have no answers... e.g.

Will it reopen? If so, when? Why did it close? Where can I get more information? Should I check back later? Etc.

All I know is that it's closed indefinitely and there doesn't seem like a lot of urgency to replace it with something. I have a few ideas, but again, it doesn't seem like a priority currently.

@DanSoschin
Copy link

We could elaborate slightly:

Thank you for visiting the swag store. Unfortunately, the swag store is currently closed until further notice. There is no current timeline for reopening, but you can check back here for updates or follow WordPress on social media where any announcements will be made.

@thetinyl
Copy link
Collaborator

thetinyl commented Jun 5, 2024

The challenge here is that there are likely many questions ... to which I have no answers... e.g.

This is the big challenge of the day, for sure.

We could elaborate slightly:

Thank you for visiting the swag store. Unfortunately, the swag store is currently closed until further notice. There is no current timeline for reopening, but you can check back here for updates or follow WordPress on social media where any announcements will be made.

I agree with @StevenDufresne that leaving it at "The store is closed." feels very abrupt and doesn't answer anything, but I'm also wary of inviting folks to hope or "check back here" when there isn't any real plan in place to reboot Mercantile at the moment (as per @DanSoschin's suggestion).

I wonder though... are there still avenues to get swag that aren't the Mercantile? Will WordCamps/meetups still have swag? If so, this could be an opportunity to cross-promote events instead. Then it's less of a dead end.

Example:

The Mercantile: WordPress Swag Store has closed its doors for now. Thanks for always wearing your love of WordPress for all to see, and for supporting the WordPress Foundation.

Looking for another way to find swag and connect with fellow WordPressers? Check out a WordPress event near you.

@DanSoschin
Copy link

Plus one to Lauren's copy. There is swag at most WordCamps, though it's not a given. I love the idea of cross-promoting events.

@adamwoodnz
Copy link
Contributor Author

Content updated, how does this look?

Screenshot 2024-06-06 at 9 07 59 AM

@DanSoschin
Copy link

DanSoschin commented Jun 5, 2024 via email

@jasmussen
Copy link
Contributor

Thanks for the overnight conversation. To your suggestion, Adam, and coming back to this, I'm more drawn to the much smaller and more muted h6-size heading, with no borders, this one.

I still feel like we should reduce the text—"for now" feels like plenty of context to me—but Laurens copy is better!

Copy link
Contributor

@renintw renintw left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The content renders well 👍
Just a PHPCS suggestion.

<!-- /wp:heading -->

<!-- wp:paragraph -->
<p><?php _e( 'The Mercantile: WordPress Swag Store has closed its doors for now. Thanks for always wearing your love of WordPress for all to see, and for supporting the WordPress Foundation.', 'wporg' ); ?></p>
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Saw the warning suggesting changing to esc_html_e()
All output should be run through an escaping function (like esc_html_e() or esc_attr_e()), found '_e'.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This was probably generated with the sync script, which uses _e(). If we wanted to escape it, we would need to figure out the context of the strings to know if we need esc_html_e, esc_attr_e, esc_url_e, or wp_kses (for strings with HTML). I don't think it's too big of an issue here.

@adamwoodnz
Copy link
Contributor Author

Design updated:

localhost_8888_about_swag_(5 1440x900)

I'll ship and any further refinements can be made in the editor and synced 🙏

@adamwoodnz adamwoodnz merged commit cc6c2e4 into trunk Jun 6, 2024
2 checks passed
@adamwoodnz adamwoodnz deleted the add/about-swag-page branch June 6, 2024 21:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
[Component] Content Bugs or issues related to the page content
Projects
None yet
Development

Successfully merging this pull request may close these issues.

7 participants