-
Notifications
You must be signed in to change notification settings - Fork 31
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Content updates from Page Editor #446
Conversation
903c2d5
to
3d972f5
Compare
I like how simple this design is. A few thoughts that are not blockers but could be good to try. On On This spacing aligns vertically the menu and chevron icons. Before any implementation, could be good to have @jasmussen and @marko-srb eyes on my suggestions. |
3d972f5
to
49c7a3d
Compare
49c7a3d
to
7583ea6
Compare
The link destination of this block should be translatable. See #446 (comment)
16bbf1b
to
80d1a5e
Compare
a205edc
to
76b1916
Compare
I've cleaned this up a little— switched the alignment for desktop/mobile so it matches @fcoveram's proposal, and I also switch the vertical alignment to center so the chevron is centered when the text wraps.
I'll merge this now since we wanted it deployed today, and if there are any issues remaining we can follow up in another PR/update. |
57e904f
to
6c196cb
Compare
Thank you 🙏 |
It looks great 🌟 Thanks @ryelle |
Hi, with all 100% respect for Matt Mullenweg, but an idolization of 1 person in the biggest WordPress community conference isn't that much community-driven. A better line would be: On our nl-be rosetta site, i already took the initiative by translating it to promote the "whole event", not just the talk of Matt Mullenweg. |
The content has changed in the Page Editor.
Please review, merge, and deploy.