Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Content updates from Page Editor #446

Merged
merged 2 commits into from
Jun 3, 2024
Merged

Content updates from Page Editor #446

merged 2 commits into from
Jun 3, 2024

Conversation

github-actions[bot]
Copy link
Contributor

@github-actions github-actions bot commented Jun 3, 2024

The content has changed in the Page Editor.
Please review, merge, and deploy.

@github-actions github-actions bot force-pushed the automated/content-update branch from 903c2d5 to 3d972f5 Compare June 3, 2024 15:26
@fcoveram
Copy link

fcoveram commented Jun 3, 2024

I like how simple this design is. A few thoughts that are not blockers but could be good to try.

On 1600 and 800`, center the text and icon and reduce the spacing between them to be 8px.

Homepage banner on 1600px and 800px viewport

On 480 and 360, align the text on the left and chevron icon on the right with a padding of 23px on the sides.

Homepage banner on 480px and 360px viewport

This spacing aligns vertically the menu and chevron icons.

Wireframe of homepage on the banner area with rules

Before any implementation, could be good to have @jasmussen and @marko-srb eyes on my suggestions.

@jasmussen
Copy link
Contributor

Good feedback. I'm working on addressing it. So far I've removed the alt text, and adjusted the right-padding so the chevron lines up with the menu item on mobile:

Screenshot 2024-06-03 at 18 56 31

Screenshot 2024-06-03 at 18 56 47

Screenshot 2024-06-03 at 18 56 56

Screenshot 2024-06-03 at 18 57 03

I'm looking to get closer to your mockup for the whitespace on desktop, but it's not clear how close I can get.

@github-actions github-actions bot force-pushed the automated/content-update branch from 49c7a3d to 7583ea6 Compare June 3, 2024 17:02
@jasmussen
Copy link
Contributor

Here's the current state:

Screenshot 2024-06-03 at 19 00 59
Screenshot 2024-06-03 at 19 00 52
Screenshot 2024-06-03 at 19 00 39
Screenshot 2024-06-03 at 19 00 31
Screenshot 2024-06-03 at 19 00 21

@ryelle ryelle linked an issue Jun 3, 2024 that may be closed by this pull request
ryelle added a commit that referenced this pull request Jun 3, 2024
The link destination of this block should be translatable.

See #446 (comment)
@github-actions github-actions bot force-pushed the automated/content-update branch 2 times, most recently from 16bbf1b to 80d1a5e Compare June 3, 2024 20:56
@ryelle ryelle self-requested a review June 3, 2024 21:02
@github-actions github-actions bot force-pushed the automated/content-update branch 2 times, most recently from a205edc to 76b1916 Compare June 3, 2024 21:21
@ryelle
Copy link
Contributor

ryelle commented Jun 3, 2024

I've cleaned this up a little— switched the alignment for desktop/mobile so it matches @fcoveram's proposal, and I also switch the vertical alignment to center so the chevron is centered when the text wraps.

1600 800 480 360
home-banner-1600 home-banner-800 home-banner-480 home-banner-360

I'll merge this now since we wanted it deployed today, and if there are any issues remaining we can follow up in another PR/update.

@ryelle ryelle dismissed their stale review June 3, 2024 21:37

content was updated

@github-actions github-actions bot force-pushed the automated/content-update branch from 57e904f to 6c196cb Compare June 3, 2024 21:38
@ryelle ryelle merged commit 91fe9dc into trunk Jun 3, 2024
2 checks passed
@ryelle ryelle deleted the automated/content-update branch June 3, 2024 21:46
@jasmussen
Copy link
Contributor

Thank you 🙏

@fcoveram
Copy link

fcoveram commented Jun 4, 2024

It looks great 🌟 Thanks @ryelle

@daveloodts
Copy link

Hi, with all 100% respect for Matt Mullenweg, but an idolization of 1 person in the biggest WordPress community conference isn't that much community-driven.
What about other speakers?
What about 14 june?

A better line would be:
"Discover WordCamp Europe online: watch the live streams on 14 and 15 june".

On our nl-be rosetta site, i already took the initiative by translating it to promote the "whole event", not just the talk of Matt Mullenweg.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

WCEU small notice banner on Home page
5 participants