Re-render Attachment View if there are changes other than the current setting #8256
+7
−1
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Trac ticket: #62902
Description
wordpress-develop/src/js/media/views/attachment.js
Lines 587 to 589 in 7d10dd7
This code bails out early when the updated value matches the DOM, but the model starts with defaults (e.g., an empty title), and AJAX delays can leave values uninitialized. This can block re-renders, especially when the data becomes available post the AJAX call.
While the early return prevents unnecessary updates, it shouldn't apply when multiple changes occur simultaneously during initialization. Instead, bailing out only when a single change occurs—and it matches the DOM—ensures proper hydration and fixes the bug.
Screencast
PR-Demo.mov
This Pull Request is for code review only. Please keep all other discussion in the Trac ticket. Do not merge this Pull Request. See GitHub Pull Requests for Code Review in the Core Handbook for more details.