-
Notifications
You must be signed in to change notification settings - Fork 2.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Section Styles: Fix removal of insecure properties for block style variations #7759
Conversation
The following accounts have interacted with this PR and/or linked issues. I will continue to update these lists as activity occurs. You can also manually ask me to refresh this list by adding the Core Committers: Use this line as a base for the props when committing in SVN:
To understand the WordPress project's expectations around crediting contributors, please review the Contributor Attribution page in the Core Handbook. |
Co-authored-by: Mukesh Panchal <mukeshpanchal27@users.noreply.github.com>
Test using WordPress PlaygroundThe changes in this pull request can previewed and tested using a WordPress Playground instance. WordPress Playground is an experimental project that creates a full WordPress instance entirely within the browser. Some things to be aware of
For more details about these limitations and more, check out the Limitations page in the WordPress Playground documentation. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This is testing nicely for me. I followed similar testing instructions to WordPress/gutenberg#66896 using the Assembler theme to test the output of section styles, and via applying the Noir styles variation. With this PR applied, (and with color-mix
enabled in kses.php
), the section styles rules are output as expected:
As in the Gutenberg PR, I like how this splits the logic out into separate methods, and that the tests are explicit about which things should be stripped — both help improve readability to me 👍
LGTM! 🚀
Co-authored-by: Andrew Serong <14988353+andrewserong@users.noreply.github.com>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This looks good to me and I've validated the fix by comparing the tests on this branach and on trunk.
I see Andrew's done some manual testing too.
This PR backports the PHP changes from WordPress/gutenberg#66896
These changes prevent valid inner block type and element styles from being stripped out of block style variations via
remove_insecure_properties
.Trac ticket: https://core.trac.wordpress.org/ticket/62372
Testing Instructions
unfiltered_html
caps e.g. site adminMore detailed instructions testing with the Assembler block theme can be found on the original Gutenberg PR. It also has some test block markup.
This Pull Request is for code review only. Please keep all other discussion in the Trac ticket. Do not merge this Pull Request. See GitHub Pull Requests for Code Review in the Core Handbook for more details.