Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Section Styles: Fix removal of insecure properties for block style variations #7759

Conversation

aaronrobertshaw
Copy link

This PR backports the PHP changes from WordPress/gutenberg#66896

These changes prevent valid inner block type and element styles from being stripped out of block style variations via remove_insecure_properties.

Trac ticket: https://core.trac.wordpress.org/ticket/62372

Testing Instructions

  1. Ensure unit tests are passing
  2. Using a multisite install, login with a user that has access to the Site Editor but doesn't have unfiltered_html caps e.g. site admin
  3. Activate a theme that within a theme style variation defines a block style variation containing inner block and element styles
  4. Navigate to Appearance > Editor
  5. Edit a page or template and apply the block style variation from step 3
  6. Save changes
  7. Apply the theme style variation identified in step 3.
  8. Re-save changes and switch to the frontend
  9. Confirm that the block with the block style variation applied gets the correct styles defined within the theme style variation.

More detailed instructions testing with the Assembler block theme can be found on the original Gutenberg PR. It also has some test block markup.


This Pull Request is for code review only. Please keep all other discussion in the Trac ticket. Do not merge this Pull Request. See GitHub Pull Requests for Code Review in the Core Handbook for more details.

Copy link

github-actions bot commented Nov 11, 2024

The following accounts have interacted with this PR and/or linked issues. I will continue to update these lists as activity occurs. You can also manually ask me to refresh this list by adding the props-bot label.

Core Committers: Use this line as a base for the props when committing in SVN:

Props aaronrobertshaw, peterwilsoncc, mukesh27, andrewserong.

To understand the WordPress project's expectations around crediting contributors, please review the Contributor Attribution page in the Core Handbook.

Co-authored-by: Mukesh Panchal <mukeshpanchal27@users.noreply.github.com>
Copy link

Test using WordPress Playground

The changes in this pull request can previewed and tested using a WordPress Playground instance.

WordPress Playground is an experimental project that creates a full WordPress instance entirely within the browser.

Some things to be aware of

  • The Plugin and Theme Directories cannot be accessed within Playground.
  • All changes will be lost when closing a tab with a Playground instance.
  • All changes will be lost when refreshing the page.
  • A fresh instance is created each time the link below is clicked.
  • Every time this pull request is updated, a new ZIP file containing all changes is created. If changes are not reflected in the Playground instance,
    it's possible that the most recent build failed, or has not completed. Check the list of workflow runs to be sure.

For more details about these limitations and more, check out the Limitations page in the WordPress Playground documentation.

Test this pull request with WordPress Playground.

Copy link
Contributor

@andrewserong andrewserong left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is testing nicely for me. I followed similar testing instructions to WordPress/gutenberg#66896 using the Assembler theme to test the output of section styles, and via applying the Noir styles variation. With this PR applied, (and with color-mix enabled in kses.php), the section styles rules are output as expected:

image

As in the Gutenberg PR, I like how this splits the logic out into separate methods, and that the tests are explicit about which things should be stripped — both help improve readability to me 👍

LGTM! 🚀

src/wp-includes/class-wp-theme-json.php Outdated Show resolved Hide resolved
Co-authored-by: Andrew Serong <14988353+andrewserong@users.noreply.github.com>
Copy link
Contributor

@peterwilsoncc peterwilsoncc left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This looks good to me and I've validated the fix by comparing the tests on this branach and on trunk.

I see Andrew's done some manual testing too.

@peterwilsoncc peterwilsoncc added the props-bot Adding this label triggers the Props Bot workflow for a PR. label Feb 10, 2025
@github-actions github-actions bot removed the props-bot Adding this label triggers the Props Bot workflow for a PR. label Feb 10, 2025
Copy link

A commit was made that fixes the Trac ticket referenced in the description of this pull request.

SVN changeset: 59802
GitHub commit: d71f29f

This PR will be closed, but please confirm the accuracy of this and reopen if there is more work to be done.

@github-actions github-actions bot closed this Feb 10, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants