Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix order of cleanup actions in PHP unit tests #853

Merged
merged 1 commit into from
Jan 10, 2025

Conversation

ernilambar
Copy link
Member

@ernilambar ernilambar commented Jan 10, 2025

Based on feedback from PR - #852

  • Moved delete_transient() and remove_filter() calls in unit tests before the assertion to avoid potential issues in the future

@ernilambar ernilambar force-pushed the fix-assert-phpunit-tests branch from 0a4dc34 to 8735746 Compare January 10, 2025 06:43
@ernilambar ernilambar changed the title Fix order of tearing down in PHP unit tests Fix order of cleanup actions in PHP unit tests Jan 10, 2025
@ernilambar ernilambar added [Type] Enhancement A suggestion for improvement of an existing feature Testing labels Jan 10, 2025
@ernilambar ernilambar added this to the 1.4.0 milestone Jan 10, 2025
@ernilambar ernilambar marked this pull request as ready for review January 10, 2025 06:55
Copy link

github-actions bot commented Jan 10, 2025

The following accounts have interacted with this PR and/or linked issues. I will continue to update these lists as activity occurs. You can also manually ask me to refresh this list by adding the props-bot label.

If you're merging code through a pull request on GitHub, copy and paste the following into the bottom of the merge commit message.

Co-authored-by: ernilambar <rabmalin@git.wordpress.org>
Co-authored-by: swissspidy <swissspidy@git.wordpress.org>
Co-authored-by: frantorres <frantorres@git.wordpress.org>

To understand the WordPress project's expectations around crediting contributors, please review the Contributor Attribution page in the Core Handbook.

@ernilambar ernilambar merged commit c1a1bb1 into trunk Jan 10, 2025
29 checks passed
@ernilambar ernilambar deleted the fix-assert-phpunit-tests branch January 10, 2025 11:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Testing [Type] Enhancement A suggestion for improvement of an existing feature
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants