Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add check for restricted contributors #819

Merged
merged 8 commits into from
Dec 9, 2024

Conversation

ernilambar
Copy link
Member

@ernilambar ernilambar commented Dec 6, 2024

Add check for restricted contributors.

These are few frequent encounters where readme is generated from some third party readme generator and plugin author forget to update the Contributors value in readme:

$restricted_contributors = array(
	'username',
	'your-username',
	'your_wordpress_username',
	'yourusername',
);

Edit: Add sample output

Screen Shot 2024-12-09 at 1 16 29 PM

@ernilambar ernilambar added [Type] Enhancement A suggestion for improvement of an existing feature [Team] Plugin Review Issues owned by Plugin Review Team labels Dec 6, 2024
@ernilambar ernilambar marked this pull request as ready for review December 6, 2024 07:07
Copy link

github-actions bot commented Dec 6, 2024

The following accounts have interacted with this PR and/or linked issues. I will continue to update these lists as activity occurs. You can also manually ask me to refresh this list by adding the props-bot label.

If you're merging code through a pull request on GitHub, copy and paste the following into the bottom of the merge commit message.

Co-authored-by: ernilambar <rabmalin@git.wordpress.org>
Co-authored-by: swissspidy <swissspidy@git.wordpress.org>
Co-authored-by: davidperezgar <davidperez@git.wordpress.org>

To understand the WordPress project's expectations around crediting contributors, please review the Contributor Attribution page in the Core Handbook.

@ernilambar ernilambar force-pushed the add-check-restricted-contributors branch from c89bef7 to 387b8b4 Compare December 9, 2024 04:52
@ernilambar ernilambar requested a review from swissspidy December 9, 2024 07:13
@ernilambar ernilambar added this to the 1.4.0 milestone Dec 9, 2024
@ernilambar ernilambar merged commit 4505d67 into trunk Dec 9, 2024
24 checks passed
@ernilambar ernilambar deleted the add-check-restricted-contributors branch December 9, 2024 12:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
[Team] Plugin Review Issues owned by Plugin Review Team [Type] Enhancement A suggestion for improvement of an existing feature
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants