Added check for case sensitive duplicated file names

[davidperezgar]

Fixes #710

[davidperezgar]

@swissspidy this is the part of badly names that suggested @ernilambar to move it away, so we can work on reflection tests.

[ernilambar]

@davidperezgar I have updated the test for the check. But I noticed current check does not account for the duplicated folder name. Example:

UNIT_TESTS_PLUGIN_DIR . 'test-plugin-file-type-badly-named-files-errors/sub directory/file-1.php'
UNIT_TESTS_PLUGIN_DIR . 'test-plugin-file-type-badly-named-files-errors/Sub Directory/file-2.php'

I think we should also check for folder. We should refine the check along with error code - "duplicated_files"

[davidperezgar]

Hey awesome! It's ready then to review!

[github-actions]

The following accounts have interacted with this PR and/or linked issues. I will continue to update these lists as activity occurs. You can also manually ask me to refresh this list by adding the props-bot label.

If you're merging code through a pull request on GitHub, copy and paste the following into the bottom of the merge commit message.

Co-authored-by: davidperezgar <davidperez@git.wordpress.org>
Co-authored-by: ernilambar <rabmalin@git.wordpress.org>
Co-authored-by: swissspidy <swissspidy@git.wordpress.org>

To understand the WordPress project's expectations around crediting contributors, please review the Contributor Attribution page in the Core Handbook.

[davidperezgar]

Updated check for duplicated folders.

[swissspidy]

This check and its error messages are a bit confusing. It says „duplicated file names are not permitted“, which could led one to believe that „foo/bar.php“ und „baz/bar.php“ is not OK. Bit this is only about mixed case like „bar.php“ and „BAR.php“. I recommend clarifying the error messages here, maybe even include an example in it.

[davidperezgar]

Ok!

[davidperezgar]

Yes, you're right. The error message wasn't good enough. I've clarified the Case-Sensitive idea.