Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Increase Behat test coverage #358

Merged
merged 3 commits into from
Jan 4, 2024
Merged

Increase Behat test coverage #358

merged 3 commits into from
Jan 4, 2024

Conversation

ernilambar
Copy link
Member

No description provided.

@ernilambar ernilambar marked this pull request as draft December 26, 2023 06:38
@ernilambar ernilambar force-pushed the improve-check-behat-tests branch 9 times, most recently from 924433b to 32b2eb7 Compare December 26, 2023 07:46
@ernilambar ernilambar changed the title Update check behat tests Update plugin check behat tests Dec 26, 2023
@ernilambar ernilambar marked this pull request as ready for review December 26, 2023 07:55
@ernilambar
Copy link
Member Author

cc: @swissspidy @felixarntz @mukeshpanchal27

@swissspidy swissspidy self-requested a review December 26, 2023 10:55
@swissspidy swissspidy changed the title Update plugin check behat tests Increase Behat test coverage Dec 26, 2023
@ernilambar ernilambar force-pushed the improve-check-behat-tests branch from 32b2eb7 to 2ed49cc Compare January 3, 2024 11:46
@ernilambar ernilambar force-pushed the improve-check-behat-tests branch from 9e8ddea to 0daca87 Compare January 3, 2024 11:50
mukeshpanchal27
mukeshpanchal27 reviewed Jan 4, 2024
View reviewed changes
Copy link
Member

@mukeshpanchal27 mukeshpanchal27 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the PR. Left one minor suggestion.

tests/behat/features/plugin-check.feature Outdated Show resolved Hide resolved
@mukeshpanchal27 mukeshpanchal27 merged commit 11b9000 into WordPress:trunk Jan 4, 2024
14 checks passed
@ernilambar ernilambar deleted the improve-check-behat-tests branch January 4, 2024 10:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@swissspidy swissspidy swissspidy approved these changes

@mukeshpanchal27 mukeshpanchal27 mukeshpanchal27 approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@ernilambar @swissspidy @mukeshpanchal27