Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add Direct_DB_Queries_Check #336

Merged
merged 2 commits into from
Jan 3, 2024
Merged

Add Direct_DB_Queries_Check #336

merged 2 commits into from
Jan 3, 2024

Conversation

ernilambar
Copy link
Member

Fixes #29

Note:

  • I have added tests to cover my change.
  • All new and existing tests pass.

@ernilambar ernilambar force-pushed the direct-db-queries-check branch from 7e2bfcb to f84a5c7 Compare December 13, 2023 05:50
@ernilambar
Copy link
Member Author

cc: @swissspidy @felixarntz @mukeshpanchal27

felixarntz
felixarntz approved these changes Jan 2, 2024
View reviewed changes
Copy link
Member

@felixarntz felixarntz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@ernilambar I think this looks good. Since that is clearly a WordPress best practice, and since it's a simple check that only triggers warnings, I think it could be merged as is.

@ernilambar ernilambar force-pushed the direct-db-queries-check branch from f84a5c7 to 1a8a54c Compare January 3, 2024 04:17
mukeshpanchal27
mukeshpanchal27 reviewed Jan 3, 2024
View reviewed changes
Copy link
Member

@mukeshpanchal27 mukeshpanchal27 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @ernilambar for the PR. I've provided some feedback, but aside from those points, everything appears to be in good shape from my perspective.

tests/phpunit/tests/Checker/Checks/Direct_DB_Queries_Check_Tests.php Outdated Show resolved Hide resolved
tests/phpunit/tests/Checker/Checks/Direct_DB_Queries_Check_Tests.php Show resolved Hide resolved
@ernilambar ernilambar force-pushed the direct-db-queries-check branch from 0ea82c9 to 7fa609b Compare January 3, 2024 04:43
@ernilambar
Copy link
Member Author

ernilambar commented Jan 3, 2024 •
edited
Loading

PR has been updated and ready to review.

@mukeshpanchal27 mukeshpanchal27 merged commit 0162771 into WordPress:trunk Jan 3, 2024
25 checks passed
@ernilambar ernilambar deleted the direct-db-queries-check branch January 3, 2024 09:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@felixarntz felixarntz felixarntz approved these changes

@mukeshpanchal27 mukeshpanchal27 mukeshpanchal27 approved these changes

@swissspidy swissspidy Awaiting requested review from swissspidy

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Create Direct_DB_Queries_Check
3 participants
@ernilambar @felixarntz @mukeshpanchal27