Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add Enqueued_Styles_Size_Check #333

Merged
merged 6 commits into from
Jul 2, 2024
Merged

Add Enqueued_Styles_Size_Check #333

merged 6 commits into from
Jul 2, 2024

Conversation

ernilambar
Copy link
Member

Fixes #19

Note:

  • I have added tests to cover my change.
  • All new and existing tests pass.

@davidperezgar davidperezgar added [Team] Plugin Review Issues owned by Plugin Review Team [Team] Performance Issues owned by Performance Team and removed [Team] Plugin Review Issues owned by Plugin Review Team labels Jun 22, 2024
@davidperezgar
Copy link
Member

I've changed the tag so the Performance Team can review it.

swissspidy
swissspidy approved these changes Jul 1, 2024
View reviewed changes
Copy link
Member

@swissspidy swissspidy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

IDK why this wasn't picked up earlier, apologies!

Given that this adapts Enqueued_Scripts_Size_Check for styles, it looks pretty straightforward.

Just one suggestion regarding i18n.

@swissspidy
Copy link
Member

Related:

Maybe we could add this here as well from the beginning?

@ernilambar @swissspidy
Make message translatable
a0f1385 
Co-authored-by: Pascal Birchler <pascal.birchler@gmail.com>
@swissspidy swissspidy mentioned this pull request Jul 1, 2024
Closed
@swissspidy
Copy link
Member

In a separate PR we can look into creating an abstract class or so to reduce code repetition between this class and Enqueued_Scripts_Size_Check

@mukeshpanchal27 mukeshpanchal27 merged commit 0fd7a49 into WordPress:trunk Jul 2, 2024
17 of 18 checks passed
@swissspidy swissspidy modified the milestones: 1.1.0, 1.0.2 Jul 3, 2024
@ernilambar ernilambar deleted the enqueued-styles-size-check branch July 12, 2024 10:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@swissspidy swissspidy swissspidy approved these changes

@mukeshpanchal27 mukeshpanchal27 mukeshpanchal27 approved these changes

@westonruter westonruter westonruter approved these changes

@adamsilverstein adamsilverstein Awaiting requested review from adamsilverstein

Assignees
No one assigned
Labels
[Team] Performance Issues owned by Performance Team
Projects
WP Performance 2024
Status: Done 😃
Milestone
1.0.2
Development

Successfully merging this pull request may close these issues.

Create Enqueued_Styles_Size_Check
5 participants
@ernilambar @davidperezgar @swissspidy @westonruter @mukeshpanchal27