Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Dataviews: Fix alignment issue of "Title" column header #68840

Open
wants to merge 1 commit into
base: trunk
Choose a base branch
from

Conversation

im3dabasia
Copy link
Contributor

Closes: #68838

What?

This PR addresses the issue where the "Title" column header is not properly aligned in Dataviews when a titleField is set. The column header shifts to the left, misaligned with the search box above and the rows below.

Why?

The issue is caused by an extra margin-left on the dataviews-view-table-header.

How?

Removes the conflicting margin-left to restore proper header alignment.

Testing Instructions

  1. Run npm run storybook.
  2. Open the Dataviews story in Storybook.
  3. Check the header alignment for the first column.
  4. Ensure the "Title" column header is now properly aligned.

Screenshots

Before After
Screenshot 2025-01-22 at 11 25 35 PM Screenshot 2025-01-22 at 11 24 12 PM

Copy link

The following accounts have interacted with this PR and/or linked issues. I will continue to update these lists as activity occurs. You can also manually ask me to refresh this list by adding the props-bot label.

If you're merging code through a pull request on GitHub, copy and paste the following into the bottom of the merge commit message.

Co-authored-by: im3dabasia <im3dabasia1@git.wordpress.org>
Co-authored-by: ecgan <ecgan@git.wordpress.org>

To understand the WordPress project's expectations around crediting contributors, please review the Contributor Attribution page in the Core Handbook.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

titleField column header is not aligned in Dataviews
1 participant