Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Release Workflow: Install Subversion #68837

Merged
merged 3 commits into from
Jan 23, 2025
+8 −0
Merged

Release Workflow: Install Subversion #68837

Changes from 1 commit
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
be92551
Release Workflow: Install Subversion
Mamaduka Jan 22, 2025
7a29079
Feedback
Mamaduka Jan 22, 2025
04089c5
Update 'upload-tag' job
Mamaduka Jan 22, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 3 additions & 0 deletions .github/workflows/upload-release-to-plugin-repo.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -167,6 +167,9 @@ jobs:
VERSION: ${{ github.event.release.name }}

steps:
- name: Install Subversion
run: |
apt-get update -y && apt-get install -y subversion
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is probably good assuming svn doesn't get added back to these boxes, otherwise it will be a little wasteful.

Are there any circumstances where the upload-tag job is run below without first running the upload job? If so, this should be handled in it's own job.

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

From what I can see in the workflow, upload-tag might run for minor release and changelog updates.

This means we should also add the svn installation step to the upload-tag job, correct?

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ah, I see. Both run in github.event.release.assets[0] is truthy, but which one depends on whether needs.compute-should-update-trunk.outputs.should_update_trunk is true or not.

Perhaps it's better to add a job prior to these two that run if: github.event.release.assets[0] assuming both jobs run on the same environment. @desrosj what would you recommend?

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Perhaps it's better to add a job prior to these two that run if: github.event.release.assets[0] assuming both jobs run on the same environment. @desrosj what would you recommend?

Do you mean have a separate job before upload and upload-tag that installs SVN? If so, that unfortunately does not work. Each job is run on a separate, fresh runner machine. So we would need to add the step above to both of those jobs.

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Updated in 04089c5.

Mamaduka marked this conversation as resolved.
Show resolved Hide resolved
- name: Check out Gutenberg trunk from WP.org plugin repo
run: |
svn checkout "$PLUGIN_REPO_URL/trunk" --username "$SVN_USERNAME" --password "$SVN_PASSWORD"
Expand Down
Loading