Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Post Terms: Removing wp_kses_post causing issue #68810

Open
wants to merge 1 commit into
base: trunk
Choose a base branch
from

Conversation

benazeer-ben
Copy link
Contributor

What?

Fixes: #68742

Why?

The bg color of the prefix and suffix format is different from the normal display.

How?

Removing wp_kses_post which causing the issue.

As mentioned in this ticket

This probably isn't really necessary, but for consistency with the other blocks that have RichText fields and server-render those fields, I thought we could add it in. (Happy to close this out if folks think it doesn't need it).

This removal mightn't affect anything.

Testing Instructions

  • Open a post or page.
  • Insert a Post Terms block.
  • Set the Prefix to a Color from the toolbar.
  • When you look at the front you can see that the Background is not being rendered.

Screenshots or screencast

Uploading Screenshare - 2025-01-21 8_38_06 PM.mp4…

Copy link

The following accounts have interacted with this PR and/or linked issues. I will continue to update these lists as activity occurs. You can also manually ask me to refresh this list by adding the props-bot label.

If you're merging code through a pull request on GitHub, copy and paste the following into the bottom of the merge commit message.

Co-authored-by: benazeer-ben <benazeer@git.wordpress.org>
Co-authored-by: kartikmehta8 <kartikmehta@git.wordpress.org>
Co-authored-by: shimotmk <shimotomoki@git.wordpress.org>

To understand the WordPress project's expectations around crediting contributors, please review the Contributor Attribution page in the Core Handbook.

@Mamaduka Mamaduka changed the title Removing wp_kses_post causing issue Post Terms: Removing wp_kses_post causing issue Jan 22, 2025
@Mamaduka Mamaduka added [Type] Bug An existing feature does not function as intended [Block] Post Terms Affects the Post Terms Block labels Jan 22, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
[Block] Post Terms Affects the Post Terms Block [Type] Bug An existing feature does not function as intended
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Post Terms block: The color of the prefix and suffix format is different from the normal display
2 participants