Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Components: Fix placeholder color inconsistency across SearchControl, TextControl, Inputcontrol #68807

Open
wants to merge 1 commit into
base: trunk
Choose a base branch
from

Conversation

im3dabasia
Copy link
Contributor

@im3dabasia im3dabasia commented Jan 21, 2025

Closes: #64666

What?

This PR ensures a consistent placeholder color across the InputControl, SearchControl, and TextControl components by defining the color explicitly.

Why?

To address the issue where placeholder color varied depending on the applied styles.

How?

The placeholder color has been defined at the component level to avoid inconsistencies and improve accessibility.

Testing Instructions

  1. Test the InputControl, SearchControl, and TextControl components in the storybook
  2. Ensure the placeholder color is consistent and meets the contrast ratio requirements.
Component Foreground Color Background Color
InputControl #1e1e1e9e (dark gray 62% opacity) #ffffff (white)
SearchControl #1e1e1e9e (dark gray 62% opacity) #f0f0f0 (light gray)
TextControl #1e1e1e9e (dark gray 62% opacity) #ffffff (white)

Screenshots

SearchControl

Before After
image image

TextControl

Before After
image image

InputControl

Before After
image image

@im3dabasia im3dabasia requested a review from ajitbohra as a code owner January 21, 2025 13:12
@im3dabasia
Copy link
Contributor Author

  • This PR aims to standardize the placeholder colors for the three components mentioned above. There has been an ongoing discussion about potentially removing the light gray color from the SearchControl, as noted in this issue comment.

  • I am happy to take on the task of working on removing the color, if needed.

Copy link

github-actions bot commented Jan 21, 2025

The following accounts have interacted with this PR and/or linked issues. I will continue to update these lists as activity occurs. You can also manually ask me to refresh this list by adding the props-bot label.

If you're merging code through a pull request on GitHub, copy and paste the following into the bottom of the merge commit message.

Co-authored-by: im3dabasia <im3dabasia1@git.wordpress.org>
Co-authored-by: Mamaduka <mamaduka@git.wordpress.org>
Co-authored-by: t-hamano <wildworks@git.wordpress.org>

To understand the WordPress project's expectations around crediting contributors, please review the Contributor Attribution page in the Core Handbook.

@im3dabasia
Copy link
Contributor Author

Hey @Mamaduka,

Whenever you have a moment, could you please review my PR? I’d really appreciate it.

@Mamaduka Mamaduka added [Type] Enhancement A suggestion for improvement. [Focus] Accessibility (a11y) Changes that impact accessibility and need corresponding review (e.g. markup changes). [Package] Components /packages/components labels Jan 28, 2025
@Mamaduka Mamaduka self-requested a review January 28, 2025 17:01
@Mamaduka
Copy link
Member

Thanks for working on this, @im3dabasia!

Do you mind adding before/after screenshots? You can find examples here - #64586.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
[Focus] Accessibility (a11y) Changes that impact accessibility and need corresponding review (e.g. markup changes). [Package] Components /packages/components [Type] Enhancement A suggestion for improvement.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Components: Apply consistent placeholder color
2 participants