Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix: Update error message in private actions. #68798

Open
wants to merge 1 commit into
base: trunk
Choose a base branch
from

Conversation

kartikmehta8
Copy link

What?

Why?

This PR improves error handling in the Gutenberg editor by providing more specific and user-friendly error messages when saving operations fail. It replaces the generic "Saving failed" message with detailed context, making it easier to identify the issue and troubleshoot.
Closes #57245

How?

The current "Saving failed" message is too generic and does not provide sufficient information for users or developers to understand the root cause of the error.

Testing Instructions

  1. Open the browser's Developer Tools and block some API requests in the Network tab.
  2. Save changes and verify that the message "Some records could not be saved" is displayed.

Co-authored-by: kartikmehta8 <kartikmehta@git.wordpress.org>
Copy link

github-actions bot commented Jan 21, 2025

The following accounts have interacted with this PR and/or linked issues. I will continue to update these lists as activity occurs. You can also manually ask me to refresh this list by adding the props-bot label.

If you're merging code through a pull request on GitHub, copy and paste the following into the bottom of the merge commit message.

Co-authored-by: kartikmehta8 <kartikmehta@git.wordpress.org>
Co-authored-by: Mamaduka <mamaduka@git.wordpress.org>
Co-authored-by: creativecoder <grantmkin@git.wordpress.org>

To understand the WordPress project's expectations around crediting contributors, please review the Contributor Attribution page in the Core Handbook.

Copy link

👋 Thanks for your first Pull Request and for helping build the future of Gutenberg and WordPress, @kartikmehta8! In case you missed it, we'd love to have you join us in our Slack community.

If you want to learn more about WordPress development in general, check out the Core Handbook full of helpful information.

@github-actions github-actions bot added the First-time Contributor Pull request opened by a first-time contributor to Gutenberg repository label Jan 21, 2025
@Mamaduka Mamaduka added [Type] Bug An existing feature does not function as intended [Package] Editor /packages/editor labels Jan 21, 2025
@Mamaduka
Copy link
Member

Thanks for contributing, @kartikmehta8!

Somehow, I missed that #57245 is similar to #64158 when closing duplicate issues. I created a proposal last month, but the discussion is still ongoing.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
First-time Contributor Pull request opened by a first-time contributor to Gutenberg repository [Package] Editor /packages/editor [Type] Bug An existing feature does not function as intended
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Site editor: add details to "Saving failed" error message
2 participants