-
Notifications
You must be signed in to change notification settings - Fork 4.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix: DataViews edit page and template: remove multiple edit actions #68797
base: trunk
Are you sure you want to change the base?
Fix: DataViews edit page and template: remove multiple edit actions #68797
Conversation
The following accounts have interacted with this PR and/or linked issues. I will continue to update these lists as activity occurs. You can also manually ask me to refresh this list by adding the If you're merging code through a pull request on GitHub, copy and paste the following into the bottom of the merge commit message.
To understand the WordPress project's expectations around crediting contributors, please review the Contributor Attribution page in the Core Handbook. |
Thank you for doing this @Rishit30G. I have added some people in to get a code and a11y review for you on this as both aspects were brought up in the ticket. From a design perspective this is what I agreed and wanted if the 3 menu doesn't also just have one item. Is that also part of this solution? |
I would be introducing a new filter function, to separate out the Primary Actions from the dropdown and make them visible as icons only Screen.Recording.2025-01-30.at.4.23.43.PM.mov |
I agree, but having the primary actions handy is also quite convenient from a user's perceptive |
I think the current action-related design choices are intentional. The gird uses a compact version because there is limited space. It's probably better to move the conversation back to the issue before we move forward with a solution. |
Makes sense, thanks! |
I'd agree just unsetting |
Why?
This PR is intended to solve issue mentioned here #68789
How?
It removes the vertical 3 dots present ( only if one option is present in dropdown ) and replace it with the edit icon in the Template section of Editor ( Grid and Table )
Testing Instructions
Screenshots or screencast