Separate Command Palette (command + K) and Visible Template title buttons #63462
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…tons This is an odd one to keep the same design and account for improved accessibility. It's admittedly a hodgepodge. The shortcut button (Command + K) is a full-width button with the text aligned right. It has an aria-label tooltip of Command Palette so it can be accessed via a voice command of Command Palette or via the visible template name. The template name button is tabindex=-1 so it never receives focus and is also _behind_ the transparent Command + K button, so that a mouse click will always access the Command + K button and get the full width focus style. The H1 for the template name has been changed to a span. I'll add a visually hidden H1 in a follow-up commit.
|
The following accounts have interacted with this PR and/or linked issues. I will continue to update these lists as activity occurs. You can also manually ask me to refresh this list by adding the If you're merging code through a pull request on GitHub, copy and paste the following into the bottom of the merge commit message. To understand the WordPress project's expectations around crediting contributors, please review the Contributor Attribution page in the Core Handbook. |
|
Size Change: -1 B (0%) Total Size: 1.75 MB
ℹ️ View Unchanged
|
|
@alexstine - I tried another route for better H1 and command palette button labelling while still keeping all the visual interactions the same. I'm hoping to thread the needle of the visual designs and the accessibility so we can get an improvement merged. I'll be the first to admit the structure is more than a little odd. Curious to hear how it works for you. This is an alternative to #63462 |
|
@jeryj Getting closer, but not quite.
Adding a tabindex of -1 removes it from the tab order but not from screen readers other means of browsing. Thanks. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is an odd one to keep the same design and account for improved accessibility. It's admittedly a hodgepodge. The shortcut button (Command + K) is a full-width button with the text aligned right. It has an aria-label tooltip of Command Palette so it can be accessed via a voice command of Command Palette or via the visible template name. The template name button is tabindex=-1 so it never receives focus and is also behind the transparent Command + K button, so that a mouse click will always access the Command + K button and get the full width focus style. The H1 for the template name has been changed to a span. I'll add a visually hidden H1 in a follow-up commit.
What?
Why?
How?
Testing Instructions
Testing Instructions for Keyboard
Screenshots or screencast