Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix Featured Image label missing after image has been added to page #63344

Open
wants to merge 1 commit into
base: trunk
Choose a base branch
from

Conversation

dhananjaykuber
Copy link
Contributor

Fixes #63321

What?

This PR improves the accessibility and labeling of the Featured Image component in the post editor.

Why?

The current implementation lacks clear visual context for the Featured Image section, potentially confusing users unfamiliar with WordPress. It also has room for improvement in terms of accessibility for screen reader users.

How?

  • Added a visible label for the Featured Image section using an <span> element

Testing Instructions

  1. Open a new or existing post in the editor.
  2. Locate the Featured Image section in the post settings sidebar.
  3. Add Featured Image for post/ page.
  4. Verify that there's a visible "Featured Image" label above the image area.
  5. Remove the featured image and confirm that the interface reverts to the initial state with clear labeling.

Screenshots or screencast

Screenshot 2024-07-10 at 2 27 08 PM Screenshot 2024-07-10 at 2 27 20 PM

Copy link

The following accounts have interacted with this PR and/or linked issues. I will continue to update these lists as activity occurs. You can also manually ask me to refresh this list by adding the props-bot label.

If you're merging code through a pull request on GitHub, copy and paste the following into the bottom of the merge commit message.

Co-authored-by: dhananjaykuber <dhananjaykuber@git.wordpress.org>
Co-authored-by: andreawetzel <awetz583@git.wordpress.org>

To understand the WordPress project's expectations around crediting contributors, please review the Contributor Attribution page in the Core Handbook.

@afercia afercia added [Focus] Accessibility (a11y) Changes that impact accessibility and need corresponding review (e.g. markup changes). [Feature] Document Settings Document settings experience [Type] Bug An existing feature does not function as intended labels Jul 10, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
[Feature] Document Settings Document settings experience [Focus] Accessibility (a11y) Changes that impact accessibility and need corresponding review (e.g. markup changes). [Type] Bug An existing feature does not function as intended
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Featured Image label missing after image has been added to page
2 participants