Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix Calendar Block Color options are not working properly #63264

Open
wants to merge 1 commit into
base: trunk
Choose a base branch
from

Conversation

dhananjaykuber
Copy link
Contributor

Fixes #61346

What?

This PR fixes an issue with the Calendar Block where color changes (text and background) were not immediately reflected in the editor view.

Why?

Previously, when users changed the text or background color of the Calendar Block, the changes were only visible after a page refresh or in the front-end preview. This inconsistency created a poor user experience and made it difficult for users to visualize their changes in real-time.

How?

  1. Restructuring CSS to ensure color changes are applied consistently in the editor
  2. Improving the handling of text and background color classes

Testing Instructions

  1. Open the block editor and add a Calendar Block
  2. Open the block settings in the sidebar
  3. Change the text color of the Calendar Block
  4. Verify that the text color change is immediately visible in the editor
  5. Change the background color of the Calendar Block
  6. Verify that the background color change is immediately visible in the editor
  7. Save the post and view it on the front-end to ensure changes are applied correctly there as well

Screenshots or screencast

https://www.loom.com/share/055937c227674e46902d4abbe4ba3ac0?sid=cea7abb7-83e7-44ae-9bb8-4f6e42b28853

@dhananjaykuber dhananjaykuber requested a review from ajitbohra as a code owner July 8, 2024 17:37
Copy link

github-actions bot commented Jul 8, 2024

The following accounts have interacted with this PR and/or linked issues. I will continue to update these lists as activity occurs. You can also manually ask me to refresh this list by adding the props-bot label.

If you're merging code through a pull request on GitHub, copy and paste the following into the bottom of the merge commit message.

Co-authored-by: dhananjaykuber <dhananjaykuber@git.wordpress.org>
Co-authored-by: t-hamano <wildworks@git.wordpress.org>
Co-authored-by: pitamdey <pitamdey@git.wordpress.org>

To understand the WordPress project's expectations around crediting contributors, please review the Contributor Attribution page in the Core Handbook.

@kspilarski kspilarski added the [Block] Calendar Affects the Calendar Block label Jul 9, 2024
@akasunil akasunil added the [Type] Bug An existing feature does not function as intended label Jul 10, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
[Block] Calendar Affects the Calendar Block [Type] Bug An existing feature does not function as intended
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Calendar Block Color options are not working properly
3 participants